fixing if condition

AgnostiqHQ · Feb 7, 2024 · 7b70a26 · 7b70a26
1 parent 7c9b2cb
commit 7b70a26
Show file tree

Hide file tree

Showing 5 changed files with 38 additions and 61 deletions.
diff --git a/.github/workflows/man_0_assign_version.yml b/.github/workflows/man_0_assign_version.yml
@@ -40,6 +40,6 @@ jobs:
     needs:
       - license
     if: >
-      !github.event.inputs.nightly_tests_failed
+      !inputs.nightly_tests_failed
     uses: ./.github/workflows/changelog.yml
     secrets: inherit # pragma: allowlist secret
diff --git a/.github/workflows/man_1_push_to_master.yml b/.github/workflows/man_1_push_to_master.yml
@@ -55,7 +55,7 @@ jobs:
       - name: Perform the push to master if develop is ahead
         id: push
         if: >
-          !github.event.inputs.assign_version_failed
+          !inputs.assign_version_failed
         run: |
           DEVELOP_VERSION="${{ steps.get-versions.outputs.develop_version }}"
           MASTER_VERSION="${{ steps.get-versions.outputs.master_version }}"

diff --git a/.github/workflows/man_2_create_prerelease.yml b/.github/workflows/man_2_create_prerelease.yml
@@ -35,7 +35,7 @@ jobs:
     name: Create a Prerelease
     uses: ./.github/workflows/release.yml
     if: >
-      !github.event.inputs.push_to_master_failed
+      !inputs.push_to_master_failed
     with:
       prerelease: true
     secrets: inherit # pragma: allowlist secret
@@ -49,7 +49,7 @@ jobs:
       - name: Checkout master
         uses: actions/checkout@v4
         with:
-          ref: ${{ github.event.inputs.branch_name }}
+          ref: ${{ inputs.branch_name }}
 
       - name: Format Slack message
         run: |

diff --git a/.github/workflows/nightly-tests.yml b/.github/workflows/nightly-tests.yml
@@ -17,9 +17,6 @@
 name: nightly-tests
 
 on:
-  push:
-    branches:
-      - develop
   schedule:
     - cron: "0 0 * * *"
 

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -308,89 +308,69 @@ jobs:
       - name: Dump Covalent logs
         run: covalent logs
 
-      - name: Upload SDK report to Codecov with retry
+      - name: Upload SDK report to Codecov
         id: upload-sdk-report
         if: >
           env.RECOMMENDED_PLATFORM
           && (github.event_name == 'workflow_call'
           || steps.sdk-coverage.outcome == 'success')
-        uses: Wandalen/wretry.action@master
+        uses: codecov/codecov-action@v3
         with:
-          action: codecov/codecov-action@v3
-          with: |
-            files: ./sdk_coverage.xml
-            flags: SDK
-            name: "SDK Unit Tests"
-            fail_ci_if_error: true
-          attempt_limit: 5
-          attempt_delay: 5000
-
-      - name: Upload Dispatcher report to Codecov with retry
+          files: ./sdk_coverage.xml
+          flags: SDK
+          name: "SDK Unit Tests"
+          fail_ci_if_error: true
+
+      - name: Upload Dispatcher report to Codecov
         id: upload-dispatcher-report
         if: >
           env.RECOMMENDED_PLATFORM
           && (github.event_name == 'workflow_call'
           || steps.dispatcher-coverage.outcome == 'success')
-        uses: Wandalen/wretry.action@master
+        uses: codecov/codecov-action@v3
         with:
-          action: codecov/codecov-action@v3
-          with: |
-            files: ./dispatcher_coverage.xml
-            flags: Dispatcher
-            name: "Dispatcher Unit Tests"
-            fail_ci_if_error: true
-          attempt_limit: 5
-          attempt_delay: 5000
-
-      - name: Upload Functional report to Codecov with retry
+          files: ./dispatcher_coverage.xml
+          flags: Dispatcher
+          name: "Dispatcher Unit Tests"
+          fail_ci_if_error: true
+
+      - name: Upload Functional report to Codecov
         id: upload-functional-report
         if: >
           env.RECOMMENDED_PLATFORM
           && steps.functional-coverage.outcome == 'success'
-        uses: Wandalen/wretry.action@master
+        uses: codecov/codecov-action@v3
         with:
-          action: codecov/codecov-action@v3
-          with: |
-            files: ./functional_tests_coverage.xml
-            flags: Functional_Tests
-            name: "Functional Tests"
-            fail_ci_if_error: true
-          attempt_limit: 5
-          attempt_delay: 5000
-
-      - name: Upload UI backend report to Codecov with retry
+          files: ./functional_tests_coverage.xml
+          flags: Functional_Tests
+          name: "Functional Tests"
+          fail_ci_if_error: true
+
+      - name: Upload UI backend report to Codecov
         id: upload-ui-backend-report
         if: >
           env.RECOMMENDED_PLATFORM
           && (github.event_name == 'workflow_call'
           || steps.ui-backend-coverage.outcome == 'success')
-        uses: Wandalen/wretry.action@master
+        uses: codecov/codecov-action@v3
         with:
-          action: codecov/codecov-action@v3
-          with: |
-            files: ./ui_backend_coverage.xml
-            flags: UI_Backend
-            name: "UI Backend Unit Tests"
-            fail_ci_if_error: true
-          attempt_limit: 5
-          attempt_delay: 5000
-
-      - name: Upload UI frontend report to Codecov with retry
+          files: ./ui_backend_coverage.xml
+          flags: UI_Backend
+          name: "UI Backend Unit Tests"
+          fail_ci_if_error: true
+
+      - name: Upload UI frontend report to Codecov
         id: upload-ui-frontend-report
         if: >
           env.RECOMMENDED_PLATFORM
           && (github.event_name == 'workflow_call'
           || steps.ui-frontend-tests.outcome == 'success')
-        uses: Wandalen/wretry.action@master
+        uses: codecov/codecov-action@v3
         with:
-          action: codecov/codecov-action@v3
-          with: |
-            files: ./covalent_ui/webapp/coverage/clover.xml
-            flags: UI_Frontend
-            name: "UI Frontend Unit Tests"
-            fail_ci_if_error: true
-          attempt_limit: 5
-          attempt_delay: 5000
+          files: ./covalent_ui/webapp/coverage/clover.xml
+          flags: UI_Frontend
+          name: "UI Frontend Unit Tests"
+          fail_ci_if_error: true
 
       - name: Local Codecov
         id: local-codecov