Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable QElectron on Python >=3.12 #1975

Merged
merged 12 commits into from
Jan 20, 2025
Merged

Disable QElectron on Python >=3.12 #1975

merged 12 commits into from
Jan 20, 2025

Conversation

cjao
Copy link
Contributor

@cjao cjao commented Jan 17, 2025

This begins the process of deprecating Qelectrons

  • I have added the tests to cover my changes.
  • I have updated the documentation and CHANGELOG accordingly.
  • I have read the CONTRIBUTING document.

@cjao cjao requested review from a team as code owners January 17, 2025 18:40
kessler-frost
kessler-frost previously approved these changes Jan 17, 2025
Copy link
Member

@kessler-frost kessler-frost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks boss!

@cjao cjao requested a review from kessler-frost January 20, 2025 14:36
Copy link
Member

@kessler-frost kessler-frost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks 💯 !

@kessler-frost kessler-frost enabled auto-merge (squash) January 20, 2025 19:10
@cjao cjao disabled auto-merge January 20, 2025 19:13
@cjao cjao merged commit 53da917 into develop Jan 20, 2025
11 checks passed
@cjao cjao deleted the fix/py312-tests branch January 20, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants