Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests breaking on macos #1976

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Fix tests breaking on macos #1976

merged 1 commit into from
Jan 21, 2025

Conversation

cjao
Copy link
Contributor

@cjao cjao commented Jan 20, 2025

  • I have added the tests to cover my changes.
  • I have updated the documentation and CHANGELOG accordingly.
  • I have read the CONTRIBUTING document.

@cjao cjao requested review from a team as code owners January 20, 2025 20:39
@cjao
Fix tests breaking on macos
c77b1c4 
Reorder test steps to prevent side effects from unit tests affecting
the functional tests

Trigger local executor tests for PRs
@cjao
Copy link
Contributor Author

cjao commented Jan 21, 2025

See successful run: https://github.com/AgnostiqHQ/covalent/actions/runs/12889594522/job/35937217955?pr=1976

@kessler-frost kessler-frost merged commit 1a14dc4 into develop Jan 21, 2025
14 checks passed
@kessler-frost kessler-frost deleted the fix/mac-tests branch January 21, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kessler-frost kessler-frost kessler-frost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjao @kessler-frost