Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for the use of devcontainers for development in vscode #2905

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Allow for the use of devcontainers for development in vscode #2905

wants to merge 3 commits into from
+136 −48

Conversation

mikegehard
Copy link

@mikegehard mikegehard commented Jan 18, 2025 •
edited
Loading

Benefits:

  1. Quicker setup
  2. Better security - code runs in container and not your local machine.
  3. Easy to integrate into Github codespaces/workspace.
  4. Uses the same containers as are published for each release.

See #2885

@mikegehard mikegehard marked this pull request as draft January 18, 2025 20:55
@mikegehard
Copy link
Author

Still need to add some docs on how to use in both VSCode and from the command line via devcontainers CLI.

@mikegehard mikegehard marked this pull request as ready for review January 18, 2025 21:04
@mikegehard mikegehard mentioned this pull request Jan 18, 2025
Open
@mikegehard mikegehard marked this pull request as draft January 18, 2025 21:20
@mikegehard
Copy link
Author

This is failing to start in Github codespaces because of the use of the .env file. Looking into alternatives now.

@mikegehard mikegehard force-pushed the devcontainers branch 3 times, most recently from 10721b4 to e58700d Compare January 19, 2025 11:15
@mikegehard
refactor: Optimize Dockerfile
a8b2726 
Security, performance, and non-root user workflow
@mikegehard
feat: Add devcontainer configuration
07e398b 
This will allow folks to easily use devcontainers to
develop aider.
@mikegehard mikegehard force-pushed the devcontainers branch 2 times, most recently from ab612ae to 07e398b Compare January 19, 2025 13:33
@mikegehard mikegehard marked this pull request as ready for review January 19, 2025 13:33
@mikegehard
Copy link
Author

Here it is running on GitHub Codespaces:

image

@mikegehard mikegehard mentioned this pull request Jan 19, 2025
Closed
@mikegehard
chore: Upgrade base Python image from 3.10 to 3.12
45c6f08 
This reduces the number of high and medium CVEs
to 0 for the image.
@mikegehard
Copy link
Author

The latest docker image won't allow you to install the dependencies via pip install -e . && pip install -r requirements/requirements-dev.txt && pre-commit install but re-working the Dockerfile fixes that issue.

@mikegehard mikegehard mentioned this pull request Jan 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mikegehard