Allow users to vary the size of the byteArrayBuffer in source connectors #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aindriu Lavelle <[email protected]>
aindriu-aiven
changed the title
Claudenw
requested changes
Jan 14, 2025
commons/src/main/java/io/aiven/kafka/connect/common/config/SchemaRegistryFragment.java
Outdated
Show resolved
Hide resolved
commons/src/main/java/io/aiven/kafka/connect/common/config/SchemaRegistryFragment.java
Outdated
Show resolved
Hide resolved
commons/src/test/java/io/aiven/kafka/connect/common/config/SchemaRegistryFragmentTest.java
Outdated
Show resolved
Hide resolved
commons/src/main/java/io/aiven/kafka/connect/common/source/input/Transformer.java
Show resolved
Hide resolved
commons/src/test/java/io/aiven/kafka/connect/common/source/input/AvroTransformerTest.java
Outdated
Show resolved
Hide resolved
commons/src/main/java/io/aiven/kafka/connect/common/source/input/ByteArrayTransformer.java
Show resolved
Hide resolved
aindriu-aiven
changed the title
aindriu-aiven
force-pushed
the
aindriu-aiven/make-byte-buffer-configureable
branch
from
1821406 to
e45686e
Compare
muralibasani
requested changes
Jan 14, 2025
commons/src/main/java/io/aiven/kafka/connect/common/config/SchemaRegistryFragment.java
Outdated
Show resolved
Hide resolved
commons/src/main/java/io/aiven/kafka/connect/common/config/SchemaRegistryFragment.java
Outdated
Show resolved
Hide resolved
commons/src/main/java/io/aiven/kafka/connect/common/config/SchemaRegistryFragment.java
Outdated
Show resolved
Hide resolved
commons/src/main/java/io/aiven/kafka/connect/common/config/TransformerFragment.java
Outdated
Show resolved
Hide resolved
commons/src/main/java/io/aiven/kafka/connect/common/source/input/Transformer.java
Show resolved
Hide resolved
aindriu-aiven
force-pushed
the
aindriu-aiven/make-byte-buffer-configureable
branch
3 times, most recently
from
d662053 to
2348113
Compare
commons/src/main/java/io/aiven/kafka/connect/common/config/TransformerFragment.java
Outdated
Show resolved
Hide resolved
commons/src/main/java/io/aiven/kafka/connect/common/config/TransformerFragment.java
Show resolved
Hide resolved
commons/src/main/java/io/aiven/kafka/connect/common/config/TransformerFragment.java
Outdated
Show resolved
Hide resolved
|
|
||
| final StreamSpliterator spliterator = createSpliterator(inputStreamIOSupplier, topic, topicPartition, | ||
| sourceConfig); | ||
| final StreamSpliterator spliterator = createSpliterator(inputStreamIOSupplier, streamLength, topic, |
There was a problem hiding this comment.
Suggested change
| final StreamSpliterator spliterator = createSpliterator(inputStreamIOSupplier, streamLength, topic, | |
| final StreamSpliterator spliterator = createSpliterator(inputStreamIOSupplier, objectSize, topic, |
Stream does not have a length in general. Here iterator is sending object size, and in this repo, we are dealing with objects.
There was a problem hiding this comment.
It is referring to the stream which has been input into the createSpliterator method.
This is commons code and is not specific to the object size but the stream length.
changing the name would be a misnomer i feel.
There was a problem hiding this comment.
This repo mainly deals with cloud storage objects. Even if it's common, and when we use it for azure or gcp, I think objectSize or something similar looks better to me
There was a problem hiding this comment.
I'll let @Claudenw be the deciding vote on that one 👍
commons/src/main/java/io/aiven/kafka/connect/common/source/input/ByteArrayTransformer.java
Show resolved
Hide resolved
commons/src/main/java/io/aiven/kafka/connect/common/source/input/ByteArrayTransformer.java
Show resolved
Hide resolved
commons/src/main/java/io/aiven/kafka/connect/common/source/input/ByteArrayTransformer.java
Show resolved
Hide resolved
commons/src/test/java/io/aiven/kafka/connect/common/source/input/AvroTransformerTest.java
Outdated
Show resolved
Hide resolved
commons/src/test/java/io/aiven/kafka/connect/common/source/input/ByteArrayTransformerTest.java
Show resolved
Hide resolved
commons/src/test/java/io/aiven/kafka/connect/common/source/input/ParquetTransformerTest.java
Outdated
Show resolved
Hide resolved
muralibasani
requested changes
Jan 15, 2025
commons/src/main/java/io/aiven/kafka/connect/common/config/TransformerFragment.java
Show resolved
Hide resolved
aindriu-aiven
force-pushed
the
aindriu-aiven/make-byte-buffer-configureable
branch
from
2348113 to
1ea3437
Compare
… in the future. Signed-off-by: Aindriu Lavelle <[email protected]>
aindriu-aiven
force-pushed
the
aindriu-aiven/make-byte-buffer-configureable
branch
from
1ea3437 to
f6b6adf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to decide how large they wish to chunk the byte stream in the source connectors.
One change was to use the SourceCommonConfig instead of the abstractConfig in the transformers so that the new calls to get the maxbytebuffer would be available.
It also adds the stream length to the Transformer which should lead to improvements specifically in the ByteArrayTransformer.