Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused function #123

Merged
merged 4 commits into from
Oct 8, 2024
Merged

remove unused function #123

merged 4 commits into from
Oct 8, 2024

Conversation

NormannK
Copy link
Contributor

@NormannK NormannK commented Oct 7, 2024

replace_nan_with_none(data) is not needed anymore since we don't have any NaN values. Another 13% speed increase.

replace_nan_with_none(data) is not needed anymore since we don't have any NaN values. Another 13% speed increase.
Copy link
Contributor

@drbacke drbacke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

13% is impossible, this function is called once.
Also the use of zero values is not allowed, because zero is a valid value. But some results cannot be determined for the first entry. So there must be a placeholder, like None oder Null.

@NormannK
Copy link
Contributor Author

NormannK commented Oct 8, 2024

change es requested in #132
13% is absolutely possible since we call this function ~160 times per optimization generation!
Please check if other values need to be set since we don't have a test for them or a documentation

@NormannK NormannK requested a review from drbacke October 8, 2024 08:44
Copy link
Contributor

@drbacke drbacke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work. Thanks for changing :-)

@drbacke drbacke merged commit ac0eacb into Akkudoktor-EOS:main Oct 8, 2024
2 checks passed
@NormannK NormannK deleted the patch-1 branch October 8, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants