Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown Plugin #1314

Closed
wants to merge 0 commits into from
Closed

Markdown Plugin #1314

wants to merge 0 commits into from

Conversation

benjamin-kirkbride
Copy link
Contributor

@benjamin-kirkbride benjamin-kirkbride commented Jun 30, 2023 •
edited
Loading

This is my start of the Markdown Plugin.

Features:

  • indenting and dedenting of list items
  • pressing enter with a list will continue list at current indentation level
    • support task items
  • pressing enter on an empty list item will delete list item

This adds quite a few tests ;)

Fixes #413

Akuli
Akuli reviewed Jul 1, 2023
View reviewed changes
Copy link
Owner

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

porcupine/plugins/markdown.py Outdated Show resolved Hide resolved
porcupine/plugins/markdown.py Outdated Show resolved Hide resolved
Akuli
Akuli reviewed Jul 1, 2023
View reviewed changes
porcupine/plugins/markdown.py Outdated Show resolved Hide resolved
This was referenced Jul 2, 2023
Open
Open
Akuli
Akuli reviewed Jul 2, 2023
View reviewed changes
tests/test_markdown_plugin.py Outdated Show resolved Hide resolved
@Akuli
Copy link
Owner

Akuli commented Jul 3, 2023

I fixed a couple git things, so you will probably need git pull before your next push. I think I will have time to review this tomorrow or the day after tomorrow. You can @ me if I forget :)

@benjamin-kirkbride
Copy link
Contributor Author

Sorry about the mess there, I'm not the best at using git

@benjamin-kirkbride benjamin-kirkbride mentioned this pull request Jul 3, 2023
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akuli Akuli Akuli left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

markdown unwanted indent
2 participants
@benjamin-kirkbride @Akuli