Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete platformdirs dependency #1511

Merged
merged 18 commits into from
Jun 9, 2024
Merged

Delete platformdirs dependency #1511

merged 18 commits into from
Jun 9, 2024

Conversation

Akuli
Copy link
Owner

@Akuli Akuli commented Jun 4, 2024

Discussed in #1507

@Moosems Thanks for suggesting this to me :)

@Akuli Akuli marked this pull request as ready for review June 4, 2024 21:18
@Akuli Akuli requested a review from rdbende June 4, 2024 21:45
@Moosems
Copy link
Contributor

Moosems commented Jun 5, 2024

How was Windows heck?

@Akuli
Copy link
Owner Author

Akuli commented Jun 5, 2024

Not as bad as I expected (was easy enough to print stuff in github actions), but also not fully done. I still need to check that this works on my work computer, which unfortunately uses Windows.

@Moosems
Copy link
Contributor

Moosems commented Jun 5, 2024

my work computer... unfortunately uses Windows.

It what?

@Akuli Akuli merged commit fb0534b into main Jun 9, 2024
18 checks passed
@Akuli Akuli deleted the bye-platformdirs branch June 9, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants