-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing tier 3 token section #41
Conversation
Reviewer's Guide by SourceryThis pull request adds a missing tier 3 token section to the Updated class diagram for AuroBackground componentclassDiagram
class AuroBackground {
+String bg
+String bgSm
+String bgMd
+String bgLg
+render()
}
AuroBackground : --background = this.bg || 'var(--ds-auro-background-container-color)'
AuroBackground : --backgroundSm = this.bgSm || 'var(--background)'
AuroBackground : --backgroundMd = this.bgMd || 'var(--backgroundSm)'
AuroBackground : --backgroundLg = this.bgLg || 'var(--backgroundMd)'
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jordanjones243 - I've reviewed your changes - here's some feedback:
Overall Comments:
- In docs/partials/api.md, was the removal of the code snippet intentional? If not, consider adding the updated SCSS code snippet there as well for consistency.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
🎉 This PR is included in version 3.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #40
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Revise the SCSS variable naming for background color to improve clarity and update documentation to include a missing code snippet for the new token.
Enhancements:
Documentation: