Skip to content

Commit

Permalink
refactor: implement custom ce naming extension
Browse files Browse the repository at this point in the history
  • Loading branch information
jordanjones243 committed Apr 24, 2023
1 parent 03fa145 commit 1ed0cad
Show file tree
Hide file tree
Showing 13 changed files with 1,993 additions and 158 deletions.
3 changes: 2 additions & 1 deletion .npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,5 @@ dist/es5.js
index.html

# ignore src
src/**/*
src/**/*.scss
src/**/*.css
2 changes: 1 addition & 1 deletion apiExamples/dynamicMenu.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ function generateMenuOptionHtml(menu, label, value) {
const dynamicData = new DynamicData();
const dynamicMenuExample = document.querySelector('#dynamicMenuExample');

const input = dynamicMenuExample.shadowRoot.querySelector('auro-dropdown').querySelector('auro-input');
const input = dynamicMenuExample.shadowRoot.querySelector('combobox-dropdown').querySelector('combobox-input');

input.addEventListener('input', () => {
let data = dynamicData.getData();
Expand Down
12 changes: 5 additions & 7 deletions apiExamples/focus.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// export function focus(elem) {
const focusExample = document.querySelector('#focusExample');
const focusExampleBtnElem = document.querySelector('#focusExampleBtn');
const focusExample = document.querySelector('#focusExample');
const focusExampleBtnElem = document.querySelector('#focusExampleBtn');

focusExampleBtnElem.addEventListener('click', () => {
focusExample.focus();
});
// }
focusExampleBtnElem.addEventListener('click', () => {
focusExample.focus();
});
2 changes: 0 additions & 2 deletions apiExamples/persistent.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
const persistentExample = document.querySelector('#persistent');

console.log(persistentExample);

persistentExample.addEventListener('addNewAddress', () => {
console.warn('addNewAddress event fired');
alert(`addNewAddress event fired`);
Expand Down
4 changes: 0 additions & 4 deletions apiExamples/swapValue.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,7 @@ const btn = document.querySelector('#swapExampleBtn');
const comboboxOne = document.querySelector('#swapExampleLeft');
const comboboxTwo = document.querySelector('#swapExampleRight');

console.log("hello");
console.log(btn);

btn.addEventListener('click', () => {
console.log("btn clicked");
const valueOne = comboboxOne.value;
const valueTwo = comboboxTwo.value;

Expand Down
16 changes: 7 additions & 9 deletions demo/api.md
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ function generateMenuOptionHtml(menu, label, value) {
const dynamicData = new DynamicData();
const dynamicMenuExample = document.querySelector('#dynamicMenuExample');

const input = dynamicMenuExample.shadowRoot.querySelector('auro-dropdown').querySelector('auro-input');
const input = dynamicMenuExample.shadowRoot.querySelector('combobox-dropdown').querySelector('combobox-input');

input.addEventListener('input', () => {
let data = dynamicData.getData();
Expand Down Expand Up @@ -492,14 +492,12 @@ The focus method will apply focus state to the combobox input field.
<span slot="trigger">See code</span>

```js
// export function focus(elem) {
const focusExample = document.querySelector('#focusExample');
const focusExampleBtnElem = document.querySelector('#focusExampleBtn');

focusExampleBtnElem.addEventListener('click', () => {
focusExample.focus();
});
// }
const focusExample = document.querySelector('#focusExample');
const focusExampleBtnElem = document.querySelector('#focusExampleBtn');

focusExampleBtnElem.addEventListener('click', () => {
focusExample.focus();
});
```

```html
Expand Down
24 changes: 23 additions & 1 deletion index.js
Original file line number Diff line number Diff line change
@@ -1 +1,23 @@
export * from './dist/auro-combobox';
import { AuroInput } from '@aurodesignsystem/auro-input/src/auro-input.js';
import { AuroDropdown } from '@aurodesignsystem/auro-dropdown/src/auro-dropdown.js';
import { AuroCombobox } from './src/auro-combobox.js';

if (!customElements.get("combobox-input")) {
customElements.define("combobox-input", class extends AuroInput {});
}

if (!customElements.get("combobox-dropdown")) {
customElements.define("combobox-dropdown", class extends AuroDropdown {});
}

/**
* Register Custom Element.
* @param {Object} name - Name to use for custom element.
* @returns {void}
*/
export function registerComponent(name) {
// alias definition
if (!customElements.get(name)) {
customElements.define(name, class extends AuroCombobox {});
}
}
Loading

0 comments on commit 1ed0cad

Please sign in to comment.