feat(naming): dynamically generate unique name for auro-dropdown #127 #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-capsule42
force-pushed
the
jbaker/hashNamingPOC
branch
from
f552c47
to
4a130c8
Compare
Izook
reviewed
May 25, 2023
|
Please update commit a7bf217 to have notes that this repo was updated to Lit2.0 as well as create the new feature. Also commits b8abdee and 4a130c8 can all be merged into the single a7bf217 commit. Those updates and a repeated |
blackfalcon
previously requested changes
Jun 2, 2023
jason-capsule42
commented
Jun 15, 2023
jason-capsule42
force-pushed
the
jbaker/hashNamingPOC
branch
from
1ab3c39
to
ca1f92f
Compare
jason-capsule42
force-pushed
the
jbaker/hashNamingPOC
branch
from
ca1f92f
to
2b0fa40
Compare
|
Closing pull request in favor of new attempt: #148 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes: #127
Summary:
This work shows using a dynamically generated hash to create a unique element name used during the custom element definition
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team