-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(naming): dynamically generate unique name for auro-dropdown #127 #128
Conversation
f552c47
to
4a130c8
Compare
Please update commit a7bf217 to have notes that this repo was updated to Lit2.0 as well as create the new feature. Also commits b8abdee and 4a130c8 can all be merged into the single a7bf217 commit. Those updates and a repeated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see other comments.
1ab3c39
to
ca1f92f
Compare
ca1f92f
to
2b0fa40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing pull request in favor of new attempt: #148 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes: #127
Summary:
This work shows using a dynamically generated hash to create a unique element name used during the custom element definition
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team