-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beta #189
Beta #189
Conversation
Reviewer's Guide by SourceryThis pull request introduces several updates to the auro-combobox component, including version updates, dependency changes, and code refactoring. The changes focus on improving performance, updating to the latest dependencies, and preparing for future updates. Updated class diagram for AuroComboboxclassDiagram
class AuroCombobox {
+showBib()
+firstUpdated()
+event auroCombobox-ready
+event auroCombobox-valueSet
+event auroFormElement-validated
}
class RuntimeUtils {
+registerComponent(name, component)
}
AuroCombobox --> RuntimeUtils : uses
class LitElement {
}
AuroCombobox --> LitElement : extends
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jordanjones243 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
🎉 This PR is included in version 2.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
…s to support those updates
# [1.11.0-beta.2](v1.11.0-beta.1...v1.11.0-beta.2) (2024-08-19) ### Performance Improvements * **menu:** update menu beta version ([3ebd5cf](3ebd5cf)) * update dependencies and use auro-library build scripts ([e6a12aa](e6a12aa))
BREAKING CHANGE: trigger major release for color theme support #179
# [2.0.0-beta.1](v1.11.0-beta.2...v2.0.0-beta.1) (2024-10-03) ### Bug Fixes * update tag name attribute function parameter ([e40662d](e40662d)) ### Performance Improvements * refactor custom component registration config ([bc4fe13](bc4fe13)) * update dependencies ([9187393](9187393)) ### BREAKING CHANGES * trigger major release for color theme support #179
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: # (issue, if applicable)
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Update the auro-combobox component to support theme-enabled dependencies and improve performance by updating dependencies and using auro-library build scripts. Refactor the component registration process to utilize RuntimeUtils. Remove outdated CSS custom property fallback documentation and clean up unused scripts.
New Features:
Enhancements:
Documentation:
Chores: