Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta #189

Closed
wants to merge 13 commits into from
Closed

Beta #189

wants to merge 13 commits into from

Conversation

jordanjones243
Copy link
Contributor

@jordanjones243 jordanjones243 commented Oct 3, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: # (issue, if applicable)

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Update the auro-combobox component to support theme-enabled dependencies and improve performance by updating dependencies and using auro-library build scripts. Refactor the component registration process to utilize RuntimeUtils. Remove outdated CSS custom property fallback documentation and clean up unused scripts.

New Features:

  • Introduce support for theme-enabled dependencies in the auro-combobox component.

Enhancements:

  • Improve performance by updating the menu to a new beta version and updating dependencies.
  • Refactor the component registration process to use RuntimeUtils for registering custom elements.

Documentation:

  • Remove outdated documentation on CSS custom property fallbacks from the README.
  • Update documentation to reflect changes in the component registration process using RuntimeUtils.

Chores:

  • Remove deprecated husky script with a warning message for future failures.
  • Delete unused scripts for generating documentation and static styles.

@jordanjones243 jordanjones243 requested a review from a team as a code owner October 3, 2024 18:19
Copy link

sourcery-ai bot commented Oct 3, 2024

Reviewer's Guide by Sourcery

This pull request introduces several updates to the auro-combobox component, including version updates, dependency changes, and code refactoring. The changes focus on improving performance, updating to the latest dependencies, and preparing for future updates.

Updated class diagram for AuroCombobox

classDiagram
    class AuroCombobox {
        +showBib()
        +firstUpdated()
        +event auroCombobox-ready
        +event auroCombobox-valueSet
        +event auroFormElement-validated
    }
    class RuntimeUtils {
        +registerComponent(name, component)
    }
    AuroCombobox --> RuntimeUtils : uses

    class LitElement {
    }
    AuroCombobox --> LitElement : extends
Loading

File-Level Changes

Change Details Files
Update component version and changelog
  • Bump version to 1.11.0-beta.2
  • Add changelog entries for beta versions
  • Update performance improvements and feature additions
CHANGELOG.md
Update dependencies and CDN links
  • Remove CSS Custom Property fallbacks section
  • Update CDN links to latest versions of design-tokens, webcorestylesheets, and auro-combobox
README.md
Refactor component registration process
  • Replace custom registerComponent function with RuntimeUtils
  • Update import statements and usage in demo files
index.js
demo/index.html
demo/index.md
docs/partials/index.md
Update auro-combobox component implementation
  • Change @fires to @event in JSDoc comments
  • Remove eslint-disable-line comments
  • Update runtimeUtils usage
src/auro-combobox.js
Add ESLint configuration
  • Add new eslint.config.mjs file
  • Remove old ESLint related files
eslint.config.mjs
scripts/generateDocs.mjs
scripts/staticStyles-template.js
Remove version files for dropdown and input
  • Delete dropdownVersion.js
  • Delete inputVersion.js
src/dropdownVersion.js
src/inputVersion.js
Add Husky deprecation notice
  • Add deprecation notice for Husky in .husky/_/husky.sh
.husky/_/husky.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@CLAassistant
Copy link

CLAassistant commented Oct 3, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ jason-capsule42
✅ jordanjones243
❌ semantic-release-bot
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jordanjones243 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 1 issue found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

demo/index.md Show resolved Hide resolved
src/auro-combobox.js Show resolved Hide resolved
@blackfalcon
Copy link
Member

🎉 This PR is included in version 2.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

jason-capsule42 and others added 11 commits October 4, 2024 12:19
* **theme:** support theme enabled dependencies ([4f18baa](4f18baa))

* **deps:** update to latest dependencies and necessary config changes to support those updates ([88687c1](88687c1))
# [1.11.0-beta.2](v1.11.0-beta.1...v1.11.0-beta.2) (2024-08-19)

### Performance Improvements

* **menu:** update menu beta version ([3ebd5cf](3ebd5cf))
* update dependencies and use auro-library build scripts ([e6a12aa](e6a12aa))
BREAKING CHANGE: trigger major release for color theme support #179
# [2.0.0-beta.1](v1.11.0-beta.2...v2.0.0-beta.1) (2024-10-03)

### Bug Fixes

* update tag name attribute function parameter ([e40662d](e40662d))

### Performance Improvements

* refactor custom component registration config ([bc4fe13](bc4fe13))
* update dependencies ([9187393](9187393))

### BREAKING CHANGES

* trigger major release for color theme support #179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing arrow and weird blue box Update color tokens for theming support
5 participants