-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jbaker/beta release #192
Jbaker/beta release #192
Conversation
…s to support those updates
# [1.11.0-beta.2](v1.11.0-beta.1...v1.11.0-beta.2) (2024-08-19) ### Performance Improvements * **menu:** update menu beta version ([3ebd5cf](3ebd5cf)) * update dependencies and use auro-library build scripts ([e6a12aa](e6a12aa))
BREAKING CHANGE: trigger major release for color theme support #179
# [2.0.0-beta.1](v1.11.0-beta.2...v2.0.0-beta.1) (2024-10-03) ### Bug Fixes * update tag name attribute function parameter ([e40662d](e40662d)) ### Performance Improvements * refactor custom component registration config ([bc4fe13](bc4fe13)) * update dependencies ([9187393](9187393)) ### BREAKING CHANGES * trigger major release for color theme support #179
|
Reviewer's Guide by SourceryThis pull request implements several changes to update dependencies, improve code structure, and enhance the component's functionality. The main focus is on updating the auro-combobox component, including changes to its registration process, dependency versions, and internal logic. Sequence diagram for component registration processsequenceDiagram
participant DemoIndexHTML as demo/index.html
participant RuntimeUtils
participant AuroCombobox
DemoIndexHTML->>RuntimeUtils: import RuntimeUtils
DemoIndexHTML->>AuroCombobox: import AuroCombobox
DemoIndexHTML->>RuntimeUtils: registerComponent('custom-combobox', AuroCombobox)
RuntimeUtils->>AuroCombobox: Register as custom element
AuroCombobox-->>RuntimeUtils: Confirmation of registration
Updated class diagram for AuroComboboxclassDiagram
class AuroCombobox {
+showBib()
+firstUpdated()
-dropdown
-menu
}
class RuntimeUtils {
+registerComponent(name, component)
+handleComponentTagRename(component, tagName)
}
AuroCombobox --> RuntimeUtils : uses
note for AuroCombobox "Updated method: firstUpdated()\nUpdated logic in showBib()"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jason-capsule42 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider providing a migration guide or updated documentation to help users adapt to the new component registration process and any changes in browser support.
- Can you explain the reasoning behind removing the recent changelog entries? This could potentially confuse users about the version history.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 2 issues found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Update the Auro Combobox component to use RuntimeUtils for component registration, remove deprecated husky script, and update documentation and dependencies to align with the latest Auro Design System standards.
Enhancements:
Documentation: