Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jbaker/beta release #192

Merged
merged 13 commits into from
Oct 4, 2024
Merged

Jbaker/beta release #192

merged 13 commits into from
Oct 4, 2024

Conversation

jason-capsule42
Copy link
Member

@jason-capsule42 jason-capsule42 commented Oct 4, 2024

Alaska Airlines Pull Request

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Update the Auro Combobox component to use RuntimeUtils for component registration, remove deprecated husky script, and update documentation and dependencies to align with the latest Auro Design System standards.

Enhancements:

  • Update the registration of custom elements to use RuntimeUtils for registering 'custom-combobox'.
  • Remove deprecated husky script and provide a warning message for future failures.
  • Update dependencies in HTML and JavaScript files to use the latest versions of Auro Design System components.

Documentation:

  • Remove the section on CSS Custom Property fallbacks from the README.
  • Update documentation to reflect changes in the method of registering custom components using RuntimeUtils.

jason-capsule42 and others added 13 commits October 4, 2024 12:19
* **theme:** support theme enabled dependencies ([4f18baa](4f18baa))

* **deps:** update to latest dependencies and necessary config changes to support those updates ([88687c1](88687c1))
# [1.11.0-beta.2](v1.11.0-beta.1...v1.11.0-beta.2) (2024-08-19)

### Performance Improvements

* **menu:** update menu beta version ([3ebd5cf](3ebd5cf))
* update dependencies and use auro-library build scripts ([e6a12aa](e6a12aa))
BREAKING CHANGE: trigger major release for color theme support #179
# [2.0.0-beta.1](v1.11.0-beta.2...v2.0.0-beta.1) (2024-10-03)

### Bug Fixes

* update tag name attribute function parameter ([e40662d](e40662d))

### Performance Improvements

* refactor custom component registration config ([bc4fe13](bc4fe13))
* update dependencies ([9187393](9187393))

### BREAKING CHANGES

* trigger major release for color theme support #179
@jason-capsule42 jason-capsule42 self-assigned this Oct 4, 2024
@jason-capsule42 jason-capsule42 requested a review from a team as a code owner October 4, 2024 19:42
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ jason-capsule42
✅ jordanjones243
❌ semantic-release-bot
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

sourcery-ai bot commented Oct 4, 2024

Reviewer's Guide by Sourcery

This pull request implements several changes to update dependencies, improve code structure, and enhance the component's functionality. The main focus is on updating the auro-combobox component, including changes to its registration process, dependency versions, and internal logic.

Sequence diagram for component registration process

sequenceDiagram
    participant DemoIndexHTML as demo/index.html
    participant RuntimeUtils
    participant AuroCombobox

    DemoIndexHTML->>RuntimeUtils: import RuntimeUtils
    DemoIndexHTML->>AuroCombobox: import AuroCombobox
    DemoIndexHTML->>RuntimeUtils: registerComponent('custom-combobox', AuroCombobox)
    RuntimeUtils->>AuroCombobox: Register as custom element
    AuroCombobox-->>RuntimeUtils: Confirmation of registration
Loading

Updated class diagram for AuroCombobox

classDiagram
    class AuroCombobox {
        +showBib()
        +firstUpdated()
        -dropdown
        -menu
    }
    class RuntimeUtils {
        +registerComponent(name, component)
        +handleComponentTagRename(component, tagName)
    }
    AuroCombobox --> RuntimeUtils : uses

    note for AuroCombobox "Updated method: firstUpdated()\nUpdated logic in showBib()"
Loading

File-Level Changes

Change Details Files
Updated dependency versions and removed CSS custom property fallbacks
  • Updated design-tokens version from 4.3.1 to 4.9.2
  • Updated webcorestylesheets version from 5.0.6 to 5.1.2
  • Updated auro-combobox version from 1.10.2 to 2.0.0-beta.1
  • Removed section about CSS custom property fallbacks
README.md
Refactored component registration process
  • Removed custom registerComponent function
  • Imported RuntimeUtils from auro-library
  • Updated component registration to use RuntimeUtils
index.js
demo/index.html
demo/index.md
docs/partials/index.md
Updated internal component logic
  • Fixed a typo in handleComponentTagRename call
  • Removed unnecessary comment and eslint-disable directive
src/auro-combobox.js
Removed version files and scripts
  • Deleted dropdownVersion.js
  • Deleted inputVersion.js
  • Removed generateDocs.mjs script
  • Removed staticStyles-template.js script
src/dropdownVersion.js
src/inputVersion.js
scripts/generateDocs.mjs
scripts/staticStyles-template.js
Added deprecation notice for Husky
  • Added a deprecation notice for Husky in .husky/_/husky.sh
.husky/_/husky.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jason-capsule42 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider providing a migration guide or updated documentation to help users adapt to the new component registration process and any changes in browser support.
  • Can you explain the reasoning behind removing the recent changelog entries? This could potentially confuse users about the version history.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 2 issues found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

README.md Show resolved Hide resolved
demo/index.md Show resolved Hide resolved
src/auro-combobox.js Show resolved Hide resolved
@jason-capsule42 jason-capsule42 merged commit 0246337 into main Oct 4, 2024
18 of 20 checks passed
@jason-capsule42 jason-capsule42 deleted the jbaker/betaRelease branch October 4, 2024 19:45
@blackfalcon
Copy link
Member

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing arrow and weird blue box Update color tokens for theming support
5 participants