Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari UI fix #194

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Safari UI fix #194

merged 3 commits into from
Oct 10, 2024

Conversation

rmenner
Copy link
Contributor

@rmenner rmenner commented Oct 10, 2024

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Fix UI issues in Safari by adjusting CSS styles for input elements and improve demo readability by importing the non-minified JavaScript file.

Bug Fixes:

  • Fix UI rendering issues in Safari by updating CSS styles to use transparent colors for input border and container.

Enhancements:

  • Update demo HTML to import the non-minified JavaScript file for better readability and debugging.

@rmenner rmenner requested a review from a team as a code owner October 10, 2024 16:42
Copy link

sourcery-ai bot commented Oct 10, 2024

Reviewer's Guide by Sourcery

This pull request addresses a Safari UI issue by modifying the CSS styles for a custom component and updating a JavaScript import in the demo file. The changes focus on adjusting the appearance of the component's wrapper and updating the demo file to use a non-minified JavaScript file.

User journey diagram for Safari UI fix

journey
  title User journey for Safari UI fix
  section Before Fix
    User: Safari displays incorrect UI
  section After Fix
    User: Safari displays correct UI with updated styles
Loading

Class diagram for CSS style changes

classDiagram
  class Wrapper {
    -border-width: 0 !important
    -box-shadow: unset !important
    -outline: unset !important
    +--ds-auro-input-border-color: transparent
    +--ds-auro-input-container-color: transparent
  }
Loading

File-Level Changes

Change Details Files
Modify CSS styles for custom component wrapper
  • Remove border-color and background-color properties
  • Add CSS custom properties for border color and container color, setting them to transparent
  • Retain existing styles for border-width, box-shadow, and outline
src/style.scss
Update JavaScript import in demo file
  • Change import statement from 'index.min.js' to 'index.js'
demo/index.html

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rmenner - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The change from 'index.min.js' to 'index.js' in the import statement could potentially impact performance. Is this intentional, perhaps for development purposes?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rmenner rmenner linked an issue Oct 10, 2024 that may be closed by this pull request
@rmenner
Copy link
Contributor Author

rmenner commented Oct 10, 2024

Hey @rmenner - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The change from 'index.min.js' to 'index.js' in the import statement could potentially impact performance. Is this intentional, perhaps for development purposes?

Here's what I looked at during the review
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

This has been fixed. Cleaned up the build to include the index.min.js

@rmenner rmenner merged commit f888534 into main Oct 10, 2024
6 checks passed
@rmenner rmenner deleted the rmenner/safari-ui-fix branch October 10, 2024 19:41
@blackfalcon
Copy link
Member

🎉 This PR is included in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra outline when tab focus is used in Safari
3 participants