-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safari UI fix #194
Safari UI fix #194
Conversation
Reviewer's Guide by SourceryThis pull request addresses a Safari UI issue by modifying the CSS styles for a custom component and updating a JavaScript import in the demo file. The changes focus on adjusting the appearance of the component's wrapper and updating the demo file to use a non-minified JavaScript file. User journey diagram for Safari UI fixjourney
title User journey for Safari UI fix
section Before Fix
User: Safari displays incorrect UI
section After Fix
User: Safari displays correct UI with updated styles
Class diagram for CSS style changesclassDiagram
class Wrapper {
-border-width: 0 !important
-box-shadow: unset !important
-outline: unset !important
+--ds-auro-input-border-color: transparent
+--ds-auro-input-container-color: transparent
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rmenner - I've reviewed your changes - here's some feedback:
Overall Comments:
- The change from 'index.min.js' to 'index.js' in the import statement could potentially impact performance. Is this intentional, perhaps for development purposes?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This has been fixed. Cleaned up the build to include the index.min.js |
🎉 This PR is included in version 2.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Fix UI issues in Safari by adjusting CSS styles for input elements and improve demo readability by importing the non-minified JavaScript file.
Bug Fixes:
Enhancements: