-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add register static method #196
Conversation
Reviewer's Guide by SourceryThis pull request adds a new static No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sun-mota - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 2 issues found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
99aac14
to
f2eaa63
Compare
AuroCombobox.register is to easily register the element without extra importing `import "@aurodesignsystem/auro-combobox"` will still register this element to <auro-combobox> `import { AuroCombobox } from '../src/auro-combobox.js` wont register this element until AuroCombobox.register gets called
cba820a
to
2039d21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to revisit how we are registering menu
1. `auro-combobox` will not import `auro-menu` inside. 2. `auro-combobox` can take customized menu as a child
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #195
Summary:
AuroCombobox.register
is to easily register the element without extra importingimport "@aurodesignsystem/auro-combobox"
will still register this element to<auro-combobox>
import { AuroCombobox } from '../src/auro-combobox.js
won't register this element untilAuroCombobox.register
gets calledType of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Add a static method 'register' to the AuroCombobox class to facilitate the registration of the component with a custom name, simplifying the process and updating the documentation accordingly.
New Features:
Enhancements:
Documentation: