Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor color tokens for theming capabilities #317

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

jordanjones243
Copy link
Contributor

@jordanjones243 jordanjones243 commented May 30, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #296

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

  • Update dependencies
  • Refactor color tokens by isolating the color tokens and creating tier 3 tokens for repeatable rules
  • Replace hardcoded size values with tokens

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

Verification

  • No linter issues
  • Build:release completes without error
  • New tier 3 component tokens exist
  • API Page "Theme" section is valid

UI

  • All input texts are correct color in all states
  • All help texts are correct color in all states
  • All label texts are correct color in all states
  • Caret color is correct shade of blue
  • Type Icon color is correct color in all states
  • Alert icon is correct color
  • Clear icon is correct color
  • All border colors are correct color in all states
  • All background colors are correct color

Figma: https://www.figma.com/design/tSkHw1uJfDHy0Ml0aDp7Io/branch/SWOHKZpz2K78PPL43uvp5z/Auro-color-palette-(Variables)?node-id=4224-10856&m=dev

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@jordanjones243 jordanjones243 requested a review from a team as a code owner May 30, 2024 16:40
@jordanjones243 jordanjones243 self-assigned this May 30, 2024
@jordanjones243 jordanjones243 linked an issue May 30, 2024 that may be closed by this pull request
2 tasks
@jordanjones243 jordanjones243 force-pushed the jjones/newTokenUpdates/#296 branch 2 times, most recently from 4f8e2e0 to b3b8024 Compare May 30, 2024 18:11
src/tokens.scss Outdated Show resolved Hide resolved
src/color.scss Outdated Show resolved Hide resolved
@jordanjones243 jordanjones243 force-pushed the jjones/newTokenUpdates/#296 branch 2 times, most recently from aa66b1d to ad9cc18 Compare May 31, 2024 19:45
src/tokens.scss Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@jason-capsule42 jason-capsule42 changed the base branch from main to beta June 20, 2024 18:53
@jason-capsule42 jason-capsule42 merged commit 7df7568 into beta Jun 24, 2024
6 checks passed
@jason-capsule42 jason-capsule42 deleted the jjones/newTokenUpdates/#296 branch June 24, 2024 22:47
@blackfalcon
Copy link
Member

🎉 This PR is included in version 3.1.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon
Copy link
Member

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @beta released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update color tokens for theming support
3 participants