Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jjones/beta merge conflicts #337

Closed
wants to merge 13 commits into from
Closed

Conversation

jason-capsule42
Copy link
Member

@jason-capsule42 jason-capsule42 commented Sep 30, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: # (issue, if applicable)

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Simplify SCSS imports by removing file extensions in various style files to streamline the codebase.

Enhancements:

  • Simplify SCSS imports by removing file extensions across multiple style files.

jason-capsule42 and others added 13 commits September 30, 2024 12:29
* refactor color token structure with tier 3 tokens [#296](#296) ([f15238b](f15238b))

* **button:** use new auro-button flat variant for clear and show password ([aa46aba](aa46aba))
* **deps:** update to latest button beta version ([7be71f6](7be71f6))
* **deps:** use updated dependency versions ([c5a9fe6](c5a9fe6))
* **icon:** update to use beta of auro-icon with theme support ([9a5cfae](9a5cfae))
* replace hardcoded styles with tokens ([a7ef751](a7ef751))
* **deps:** update to use current dependency versions ([7916400](7916400))
* **deps:** update to latest beta dependencies ([42ecf61](42ecf61))
BREAKING CHANGE: trigger major release for color theming support #296
# [4.0.0-beta.1](v3.1.0-beta.3...v4.0.0-beta.1) (2024-09-30)

### Bug Fixes

* add file extensions for SSR support ([d91e0e1](d91e0e1))
* realign text and icons on non-bordered inputs [#333](#333) ([d1c1df4](d1c1df4))
* remove private default of attribute ([03e9747](03e9747))
* resolve color theming issues ([0fa4568](0fa4568))
* **theming:** resolve minor theming issues [#296](#296) ([03c3fae](03c3fae))

### Features

* **autocomplete:** add html5 autocomplete functionality [#334](#334) ([df7dd3a](df7dd3a))

### Performance Improvements

* refactor custom component registration config ([3ec2599](3ec2599))
* update dependencies ([d65d9f3](d65d9f3))

### BREAKING CHANGES

* trigger major release for color theming support #296
@jason-capsule42 jason-capsule42 requested a review from a team as a code owner September 30, 2024 20:15
Copy link

sourcery-ai bot commented Sep 30, 2024

Reviewer's Guide by Sourcery

This pull request primarily focuses on updating import statements across multiple SCSS files in the auro-input component. The changes involve removing the '.scss' file extension from import statements, which is likely a part of a broader effort to improve consistency and potentially support better module resolution.

No sequence diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update SCSS import statements
  • Remove '.scss' file extension from import statements
  • Update import paths for design tokens and other SCSS files
src/style.scss
demo/api.md
src/color.scss
src/styles/borders.scss
src/styles/helpText.scss
src/styles/input.scss
src/styles/label.scss
src/styles/notificationIcons.scss
src/tokens.scss
Update CHANGELOG.md
  • Remove entries for versions 4.0.0-beta.1, 3.1.0-beta.3, 3.1.0-beta.2, and 3.1.0-beta.1
  • Keep entry for version 3.0.1
CHANGELOG.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jason-capsule42 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider preserving recent major version histories in the CHANGELOG.md file to maintain a clear record of significant changes for developers and users.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@CLAassistant
Copy link

CLAassistant commented Sep 30, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ jason-capsule42
✅ jordanjones243
❌ semantic-release-bot
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants