Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta #338

Merged
merged 13 commits into from
Sep 30, 2024
Merged

Beta #338

merged 13 commits into from
Sep 30, 2024

Conversation

jason-capsule42
Copy link
Member

@jason-capsule42 jason-capsule42 commented Sep 30, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #328

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Release version 4.0.0-beta.1 with new autocomplete feature, several bug fixes, and performance improvements. Update documentation and refactor component registration. Introduce a new ESLint configuration for code quality.

New Features:

  • Add HTML5 autocomplete functionality to the input component.

Bug Fixes:

  • Add file extensions for SSR support.
  • Realign text and icons on non-bordered inputs.
  • Remove private default of attribute.
  • Resolve color theming issues.

Enhancements:

  • Refactor custom component registration configuration for improved performance.
  • Update dependencies to the latest versions.

Build:

  • Introduce a new ESLint configuration file for code linting.

Documentation:

  • Update documentation to include new autocomplete attribute details.

jordanjones243 and others added 11 commits September 30, 2024 13:28
BREAKING CHANGE: trigger major release for color theming support #296
# [4.0.0-beta.1](v3.1.0-beta.3...v4.0.0-beta.1) (2024-09-30)

### Bug Fixes

* add file extensions for SSR support ([d91e0e1](d91e0e1))
* realign text and icons on non-bordered inputs [#333](#333) ([d1c1df4](d1c1df4))
* remove private default of attribute ([03e9747](03e9747))
* resolve color theming issues ([0fa4568](0fa4568))
* **theming:** resolve minor theming issues [#296](#296) ([03c3fae](03c3fae))

### Features

* **autocomplete:** add html5 autocomplete functionality [#334](#334) ([df7dd3a](df7dd3a))

### Performance Improvements

* refactor custom component registration config ([3ec2599](3ec2599))
* update dependencies ([d65d9f3](d65d9f3))

### BREAKING CHANGES

* trigger major release for color theming support #296
Copy link

sourcery-ai bot commented Sep 30, 2024

Reviewer's Guide by Sourcery

This pull request introduces significant changes to the auro-input component, including updates to its theming system, improvements in functionality, and changes to its build and development setup. The changes are part of a beta release, moving from version 3.1.0-beta.3 to 4.0.0-beta.1.

No sequence diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated color theming system
  • Refactored CSS custom properties for better theming support
  • Updated color variable names for consistency with design system
  • Removed fallback properties for older browsers
src/tokens.scss
src/color.scss
demo/api.md
README.md
Added autocomplete functionality
  • Introduced new 'autocomplete' attribute
  • Updated input element to support autocomplete attribute
src/auro-input.js
src/base-input.js
demo/api.md
docs/api.md
Refactored component registration process
  • Updated component registration method
  • Changed import statements for better modularity
index.js
demo/index.html
demo/index.md
docs/partials/index.md
Updated dependencies and build process
  • Updated versions of design tokens and webcorestylesheets
  • Added new ESLint configuration
  • Removed deprecated scripts
README.md
eslint.config.mjs
scripts/generateDocs.mjs
scripts/postCss.mjs
scripts/staticStyles-template.js
Improved input styling and behavior
  • Adjusted padding and alignment of input elements
  • Updated styles for non-bordered inputs
  • Fixed color issues for disabled state
src/styles/input.scss
src/styles/label.scss
src/styles/notificationIcons.scss

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@CLAassistant
Copy link

CLAassistant commented Sep 30, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ jordanjones243
✅ jason-capsule42
❌ semantic-release-bot
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jason-capsule42 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a migration guide or detailed notes in the changelog about the breaking changes, particularly regarding color theming support.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 2 issues found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

README.md Show resolved Hide resolved
demo/api.md Outdated Show resolved Hide resolved
src/auro-input.js Show resolved Hide resolved
@jason-capsule42 jason-capsule42 merged commit a385777 into main Sep 30, 2024
8 of 9 checks passed
@blackfalcon
Copy link
Member

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text and icons are misaligned on non-bordered inputs Update color tokens for theming support
5 participants