-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beta #338
Beta #338
Conversation
BREAKING CHANGE: trigger major release for color theming support #296
# [4.0.0-beta.1](v3.1.0-beta.3...v4.0.0-beta.1) (2024-09-30) ### Bug Fixes * add file extensions for SSR support ([d91e0e1](d91e0e1)) * realign text and icons on non-bordered inputs [#333](#333) ([d1c1df4](d1c1df4)) * remove private default of attribute ([03e9747](03e9747)) * resolve color theming issues ([0fa4568](0fa4568)) * **theming:** resolve minor theming issues [#296](#296) ([03c3fae](03c3fae)) ### Features * **autocomplete:** add html5 autocomplete functionality [#334](#334) ([df7dd3a](df7dd3a)) ### Performance Improvements * refactor custom component registration config ([3ec2599](3ec2599)) * update dependencies ([d65d9f3](d65d9f3)) ### BREAKING CHANGES * trigger major release for color theming support #296
Reviewer's Guide by SourceryThis pull request introduces significant changes to the auro-input component, including updates to its theming system, improvements in functionality, and changes to its build and development setup. The changes are part of a beta release, moving from version 3.1.0-beta.3 to 4.0.0-beta.1. No sequence diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jason-capsule42 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a migration guide or detailed notes in the changelog about the breaking changes, particularly regarding color theming support.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 2 issues found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #328
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Release version 4.0.0-beta.1 with new autocomplete feature, several bug fixes, and performance improvements. Update documentation and refactor component registration. Introduce a new ESLint configuration for code quality.
New Features:
Bug Fixes:
Enhancements:
Build:
Documentation: