Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: search folders recursively during sass build tasks #341

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

chrisfalaska
Copy link
Contributor

@chrisfalaska chrisfalaska commented Oct 15, 2024

Alaska Airlines Pull Request

Recent changes to wc-generator (#579) and auro-form (#1) have prompted updates to how build tasks in package.json search for relevant files.

The build tasks for auro-input should be updated to better align with its intended consumption as part of the auro-form monorepo work in #1.

Resolves: #340

Summary:

  • Update package.json tasks to search recursively in folders
  • Update .gitignore patterns to search recursively in folders

Type of change:

Please delete options that are not relevant.

  • Revision of an existing capability

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Update build tasks to search folders recursively during SASS build tasks, introduce HTML5 autocomplete functionality, and fix various bugs related to SSR support, text alignment, and color theming. Enhance the project by refactoring color token structure, updating dependencies, and improving component registration configuration. Update documentation to reflect the latest version changes.

New Features:

  • Add HTML5 autocomplete functionality to the input component.

Bug Fixes:

  • Add file extensions for SSR support.
  • Realign text and icons on non-bordered inputs.
  • Remove private default of attribute.
  • Resolve color theming issues.

Enhancements:

  • Refactor color token structure with tier 3 tokens.
  • Use new auro-button flat variant for clear and show password.
  • Update to latest beta dependencies.
  • Update to use beta of auro-icon with theme support.
  • Refactor custom component registration config.
  • Replace hardcoded styles with tokens.

Build:

  • Update package.json tasks to search recursively in folders.

Documentation:

  • Update README to reflect the latest version of auro-input script.

@chrisfalaska chrisfalaska self-assigned this Oct 15, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ chrisfalaska
❌ semantic-release-bot
You have signed the CLA already but the status is still pending? Let us recheck it.

@chrisfalaska chrisfalaska linked an issue Oct 15, 2024 that may be closed by this pull request
@chrisfalaska chrisfalaska changed the title Cfriedberg/340 feat: scan folders recursively during sass build tasks Oct 16, 2024
@chrisfalaska chrisfalaska changed the title feat: scan folders recursively during sass build tasks feat: search folders recursively during sass build tasks Oct 16, 2024
@chrisfalaska chrisfalaska marked this pull request as ready for review October 16, 2024 19:57
@chrisfalaska chrisfalaska requested a review from a team as a code owner October 16, 2024 19:57
Copy link

sourcery-ai bot commented Oct 16, 2024

Reviewer's Guide by Sourcery

This pull request updates the build tasks in package.json to search recursively in folders for relevant files during the sass build process. It also updates the .gitignore patterns to search recursively in folders. These changes are made to align with recent updates in related projects and to support the auro-form monorepo work.

Other diagram for recursive folder search in build tasks

graph TD;
    A[Start] --> B{Search for files};
    B -->|Recursively| C[Search in all subfolders];
    C --> D[Process files];
    D --> E[End];
Loading

File-Level Changes

Change Details Files
Update build tasks to search recursively in folders
  • Modify package.json scripts to include recursive folder search
  • Update .gitignore patterns for recursive folder search
package.json
.gitignore
Update CHANGELOG.md with new version and changes
  • Add entry for version 4.0.0
  • Include various bug fixes, features, and performance improvements
CHANGELOG.md
Update README.md with new version number
  • Update CDN link to use version 4.0.0 instead of 4.0.0-beta.1
README.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chrisfalaska - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@chrisfalaska chrisfalaska merged commit 80b84af into main Oct 17, 2024
5 of 6 checks passed
@chrisfalaska chrisfalaska deleted the cfriedberg/340 branch October 17, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search folders recursively during SASS build tasks
4 participants