Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update component registration logic #49

Closed
sun-mota opened this issue Oct 17, 2024 · 0 comments · Fixed by #50
Closed

Update component registration logic #49

sun-mota opened this issue Oct 17, 2024 · 0 comments · Fixed by #50
Assignees

Comments

@sun-mota
Copy link
Contributor

Please verify the version of auro-toast you have installed

No response

Please describe the bug

Default import of index.js should register the default custom element only.

import of the component class should not register the custom element at all.

Remove all registration of custom-${component name} from the JS and only register as part of ./demo/index.js

Reproducing the error

None

Expected behavior

No response

What browsers are you seeing the problem on?

No response

Additional context

No response

Exit criteria

No response

@sun-mota sun-mota added auro-toast not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes labels Oct 17, 2024
@sun-mota sun-mota self-assigned this Oct 17, 2024
@sun-mota sun-mota linked a pull request Oct 18, 2024 that will close this issue
6 tasks
sun-mota added a commit that referenced this issue Oct 21, 2024
`AuroToast.register` is to easily register the element without extra importing
`import "@aurodesignsystem/auro-toast"` will still register this element to <auro-toast>
`import { AuroToast } from '../src/auro-toast.js` wont register this element until `AuroToast.register` gets called

Fixed the typo on Recommended Use and Version Control.
`clement` -> `element`
@jason-capsule42 jason-capsule42 removed not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes labels Oct 23, 2024
sun-mota added a commit that referenced this issue Oct 24, 2024
`AuroToast.register` is to easily register the element without extra importing
`import "@aurodesignsystem/auro-toast"` will still register this element to <auro-toast>
`import { AuroToast } from '../src/auro-toast.js` wont register this element until `AuroToast.register` gets called

Fixed the typo on Recommended Use and Version Control.
`clement` -> `element`
blackfalcon pushed a commit that referenced this issue Oct 24, 2024
# [2.1.0](v2.0.1...v2.1.0) (2024-10-24)

### Bug Fixes

* remove min-height style ([7cadc5d](7cadc5d))

### Features

* **api:** add register static method [#49](#49) ([2105fbf](2105fbf))

### Performance Improvements

* update dependency versions ([3762e5d](3762e5d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants