Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add register static method #50

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Conversation

sun-mota
Copy link
Contributor

@sun-mota sun-mota commented Oct 18, 2024

Fixed the typo on Recommended Use and Version Control. clement -> element

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #49

Summary:

AuroToast.register is to easily register the element without extra importing
import "@aurodesignsystem/auro-toast" will still register this element to
import { AuroToast } from '../src/auro-toast.js wont register this element until AuroToast.register gets called

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Add a static method AuroToast.register to facilitate the registration of the auro-toast element with a custom name, and update documentation to reflect this change. Remove the default element registration to encourage the use of the new method.

New Features:

  • Introduce a static method AuroToast.register to allow dynamic registration of the custom element with a specified name.

Enhancements:

  • Remove the default internal definition of the auro-toast element to rely on the new register method for element registration.

Documentation:

  • Correct typos in documentation, changing 'clement' to 'element'.
  • Update documentation to reflect the new AuroToast.register method for registering custom elements.

@sun-mota sun-mota self-assigned this Oct 18, 2024
@sun-mota sun-mota requested a review from a team as a code owner October 18, 2024 20:03
@sun-mota sun-mota linked an issue Oct 18, 2024 that may be closed by this pull request
Copy link

sourcery-ai bot commented Oct 18, 2024

Reviewer's Guide by Sourcery

This pull request adds a new static register method to the AuroToast class, simplifying the process of registering the custom element. It also updates the documentation and demo to reflect this change, and fixes a typo in the documentation.

Class diagram for AuroToast with new register method

classDiagram
    class AuroToast {
        +static register(name="auro-toast")
        +firstUpdated()
    }
    note for AuroToast "Added static register method to simplify element registration"
Loading

File-Level Changes

Change Details Files
Added a new static register method to the AuroToast class
  • Implemented AuroToast.register method with an optional name parameter
  • Method uses AuroLibraryRuntimeUtils.prototype.registerComponent to register the component
  • Removed the default internal definition of the custom element
src/auro-toast.js
Updated demo and documentation to use the new register method
  • Removed old registration code using RuntimeUtils
  • Added example of using AuroToast.register('custom-toast') in demo
  • Updated documentation to reflect the new registration method
demo/index.html
demo/index.md
docs/partials/index.md
demo/index.js
Fixed a typo in the documentation
  • Changed 'custom clement' to 'custom element' in multiple files
demo/index.md
docs/partials/index.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sun-mota - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟡 Documentation: 2 issues found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

demo/index.md Show resolved Hide resolved
demo/index.md Show resolved Hide resolved
demo/index.min.js Show resolved Hide resolved
demo/index.min.js Outdated Show resolved Hide resolved
demo/index.min.js Show resolved Hide resolved
demo/index.min.js Show resolved Hide resolved
demo/index.min.js Outdated Show resolved Hide resolved
demo/index.min.js Outdated Show resolved Hide resolved
@sun-mota sun-mota force-pushed the sunMota/feat/easierRegistry/49 branch from e78ccc2 to f5bee45 Compare October 18, 2024 21:42
`AuroToast.register` is to easily register the element without extra importing
`import "@aurodesignsystem/auro-toast"` will still register this element to <auro-toast>
`import { AuroToast } from '../src/auro-toast.js` wont register this element until `AuroToast.register` gets called

Fixed the typo on Recommended Use and Version Control.
`clement` -> `element`
@sun-mota sun-mota force-pushed the sunMota/feat/easierRegistry/49 branch from f5bee45 to d1e0b11 Compare October 21, 2024 18:34
@sun-mota sun-mota force-pushed the sunMota/feat/easierRegistry/49 branch from 5b4bd2e to aa480d0 Compare October 23, 2024 18:56
Copy link
Member

@jason-capsule42 jason-capsule42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After running a build there are 4 files with changes that aren't checked into this PR.

@sun-mota sun-mota merged commit 3762e5d into main Oct 24, 2024
6 checks passed
@sun-mota sun-mota deleted the sunMota/feat/easierRegistry/49 branch October 24, 2024 16:10
@blackfalcon
Copy link
Member

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auro-toast released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update component registration logic
3 participants