Improve Docker Swarm and Compose support #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since these tags are user-defined, I'm thinking that perhaps we should namespace them. Ideas:
|
|
Using tags for this makes it possible for there being any number of tags, so we need to rework the dropdown a bit to be able to scroll: 
Idea: sort the tags in the dropdown based on prefix. First, prioritize all non-prefixed tags (not containing a ":"), then sort alphabetically. |
|
I've made the tag select dropdown scrollable and sorted the namespaced tags last. 
|
AlexGustafsson
force-pushed
the
dev/namespace-stack-tags
branch
4 times, most recently
from
e2bce19 to
cc695fe
Compare
AlexGustafsson
changed the title
AlexGustafsson
changed the title
AlexGustafsson
force-pushed
the
dev/namespace-stack-tags
branch
2 times, most recently
from
66f9574 to
55f1e4b
Compare
- Identify tags even when Docker Swarm uses a digest image - Graph Docker Swarm tasks, services and namespaces - Add Docker Swarm namespace as a tag
With namespaces tags added, the list of tags can be quite long. Make the order deterministic and prioritize the built-in tags. Place prefixed tags such as "namespace:monitoring" at the end of the list.
Make sure that the tag select will scroll if there are many tags available.
Nested anchor tags (as used by the badges of the image card) are not legal. As we still want the image card to be a proper anchor, let's try our best to simulate anchors for the badges. This is not by any means a perfect solution, but will suffice for most cases.
AlexGustafsson
force-pushed
the
dev/namespace-stack-tags
branch
from
55f1e4b to
d171aeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshot of graph in Docker Swarm:
Screenshot of image with namespace tag in Docker:
Screenshot of image with namespace tag in Kubernetes: