Fix count matching to prevert number overflow

AlexProgrammerDE · Jan 29, 2025 · d838709 · d838709
1 parent d300321
commit d838709
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/server/src/main/java/com/soulfiremc/server/grpc/LoginRateLimitingInterceptor.java b/server/src/main/java/com/soulfiremc/server/grpc/LoginRateLimitingInterceptor.java
@@ -49,11 +49,11 @@ public <ReqT, RespT> ServerCall.Listener<ReqT> interceptCall(
         var count = callCache.getIfPresent(key);
         if (count == null) {
           callCache.put(key, 1);
-        } else {
+        } else if (count < RPCConstants.LOGIN_RATE_LIMIT) {
           callCache.put(key, count + 1);
         }
 
-        if (count != null && count > RPCConstants.LOGIN_RATE_LIMIT) {
+        if (count != null && count >= RPCConstants.LOGIN_RATE_LIMIT) {
           status = Status.RESOURCE_EXHAUSTED.withDescription("Too many login attempts");
         } else {
           return Contexts.interceptCall(