fix: forest coverity issues (uxlfoundation#2657)

* fix forest issues * Update dtrees_train_data_helper.i --------- Co-authored-by: Ian Faust <[email protected]>
Alexandr-Solovev · Feb 15, 2024 · 7871c22 · 7871c22
1 parent e0f791e
commit 7871c22
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/cpp/daal/src/algorithms/dtrees/dtrees_train_data_helper.i b/cpp/daal/src/algorithms/dtrees/dtrees_train_data_helper.i
@@ -115,6 +115,7 @@ struct SplitData
 
     SplitData()
         : impurityDecrease(-daal::services::internal::MaxVal<algorithmFPType>::get()),
+          left {},
           featureValue(0.0),
           nLeft(0),
           iStart(0),

diff --git a/cpp/daal/src/algorithms/dtrees/forest/df_train_dense_default_impl.i b/cpp/daal/src/algorithms/dtrees/forest/df_train_dense_default_impl.i
@@ -947,8 +947,8 @@ typename DataHelper::NodeType::Base * TrainBatchTaskBase<algorithmFPType, BinInd
         double improvement;
         algorithmFPType leftWeights;
         algorithmFPType totalWeights;
-        typename DataHelper::ImpurityData impurityLeft;
-        typename DataHelper::ImpurityData impurityRight;
+        typename DataHelper::ImpurityData impurityLeft {};
+        typename DataHelper::ImpurityData impurityRight {};
         typename DataHelper::NodeType::Split * node;
 
         WorkItem()
@@ -1132,7 +1132,7 @@ NodeSplitResult TrainBatchTaskBase<algorithmFPType, BinIndexType, DataHelper, cp
     /* zero-based index of best split */
     int64_t iBestSplit               = -1;
     int64_t idxFeatureValueBestSplit = -1;
-    typename DataHelper::TSplitData split;
+    typename DataHelper::TSplitData split {};
     /* RNG for sample drawing */
     RNGsInst<IndexType, cpu> rng;
     /* index for swapping samples in Fisher-Yates sampling */