mask tokens in logs #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On a positive note, the Nextflow developers are quite responsive, and the root cause should be fixed in the next release: nextflow-io/nextflow#5183 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since nextflow leaks tower tokens (see nextflow-io/nextflow#5183) to the log when making wave requests (and possibly elsewhere?) I am here adding
sedsteps to mask all of those. It only masks the current token value, because I didn't yet figure out what the full pattern for the Seqera tokens is.I also moved the workspace ID to 1Password, just to have both in the same place. AWS secrets have been updated to include that secret path as well.