Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results section - Additional Modalities #37

Merged
merged 16 commits into from
Mar 1, 2024

Conversation

allyhawkins
Copy link
Member

@allyhawkins allyhawkins commented Feb 20, 2024

Closes #28
Stacked on #34

This PR adds a section to the results covering additional modalities. I left one question as an html comment about how detailed we want to be with genetic demultiplexing. I gave an overview of the process, but didn't mention each individual tool that is used. We will definitely mention all of the individual tools used in the methods, but do we want to be more detailed here and include them in the text?

The sections on bulk and spatial are pretty simple, but are there additional details I should include?

@jaclyn-taroni
Copy link
Member

I started editing this in jaclyn-taroni/37-review-additional-modalities but decided it makes sense to have you look through #47, which includes a decent amount of reorganization, and/or resolve #34. Then, we should mirror how we talk about inputs/outputs/etc. there in this section.

@jaclyn-taroni jaclyn-taroni removed their request for review February 24, 2024 19:38
Base automatically changed from allyhawkins/draft-results-scpca-nf to main February 28, 2024 15:24
Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit b7d4d9f.

Manuscript build

Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit e2572c8.

Manuscript build

@allyhawkins
Copy link
Member Author

Okay I did quite a bit of reorganizing and rewriting for this section to try and follow how we talk about the main workflow. This should now be ready for @jaclyn-taroni to take a look.

Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit 09ad29d.

Manuscript build

Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit b4e2f30.

Manuscript build

Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit 4322c36.

Manuscript build

Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit 8521ce6.

Manuscript build

…ults-addn-modalities

Add edits and TODOs to the results sections on multiplexed, bulk, and spatial data
Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit 19c9f19.

Manuscript build

@allyhawkins
Copy link
Member Author

I've updated this to include the edits from both stacked PRs and filled in the TODOs.

  • For the ADT normalization citation, there isn't really a paper that I could find, but I used the OSCA section as the reference? That's what we link in our docs and there's no references there either.
  • For the demultiplexing citations, there's a paper that explains demultiplexing with Seurat, but not one for DropletUtils.

I believe I got all the other ones and this should be ready for another look @jaclyn-taroni.

Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit c1ee669.

Manuscript build

Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When in doubt, you can use the DOI of the Bioconductor package.

content/03.results.md Outdated Show resolved Hide resolved
content/03.results.md Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Mar 1, 2024

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit e64a3e6.

Manuscript build

@allyhawkins allyhawkins merged commit 713551a into main Mar 1, 2024
1 check passed
@allyhawkins allyhawkins deleted the allyhawkins/results-additional-modalities branch March 1, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Draft: Results - additional modalities
2 participants