Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Ensembl release and division for RNA-seq samples #924

Merged
merged 2 commits into from
Nov 18, 2020

Conversation

BEW111
Copy link
Contributor

@BEW111 BEW111 commented Aug 28, 2020

Issue Number

#923

Purpose/Implementation Notes

This is dependent on AlexsLemonade/refinebio/pull/2527, since it uses the release_version and database_name fields of the transcriptome indices. The processing info for a transcriptome index now shows those two fields.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Functional tests

I tested this with the current API (not the changes from #2527) and source_version shows up, and the only difference between that and the new field names is the names themselves so it should show up as long as they are in the database.

Checklist

Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Screenshots

Right now this doesn't have the entries since those would come from the changes in #2527

Screen Shot 2020-08-31 at 12 34 26 PM

@BEW111 BEW111 requested a review from jaclyn-taroni August 28, 2020 14:25
@jaclyn-taroni
Copy link
Member

I would probably put the new fields under Genome Build, rather than put that information under a new section (e.g., Database Info).

Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview LGTM 👍 - I'm not sure if anyone from engineering wants to take a look, though

@BEW111 BEW111 requested a review from kurtwheeler August 31, 2020 16:56
@kurtwheeler kurtwheeler requested review from davidsmejia and removed request for kurtwheeler August 31, 2020 17:59
@davidsmejia davidsmejia merged commit 58baa80 into dev Nov 18, 2020
@davidsmejia davidsmejia deleted the BEW111/display-ensembl-release branch November 18, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants