Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Sample: developmental_stage genetic_information #86

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Update Sample: developmental_stage genetic_information #86

merged 2 commits into from
Nov 14, 2023

Conversation

davidsmejia
Copy link
Contributor

@davidsmejia davidsmejia commented Nov 14, 2023 •
edited
Loading

Issue: #85

We have addressed some recent issues around harmonization on the refinebio API. This PR updates the parsed attributes to reflect those changes.

Issues:

Rename: genotype -> genetic_information
Added: developmental_stage

jashapiro
jashapiro approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidsmejia davidsmejia merged commit d4620ca into master Nov 14, 2023
5 checks passed
arkid15r
arkid15r reviewed Nov 14, 2023
View reviewed changes
Copy link
Contributor

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jashapiro jashapiro mentioned this pull request Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkid15r arkid15r arkid15r left review comments

@jashapiro jashapiro jashapiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidsmejia @jashapiro @arkid15r