Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OriginalFiles endpoint to API #1867

Merged
merged 6 commits into from
Nov 6, 2019
Merged

Add OriginalFiles endpoint to API #1867

merged 6 commits into from
Nov 6, 2019

Conversation

arielsvn
Copy link
Contributor

@arielsvn arielsvn commented Nov 6, 2019

Issue Number

N/A

Purpose/Implementation Notes

This adds several small improvements to the API:

  • A new original file endpoint.
  • Returns original/computed file ids on the detailed sample endpoint
  • Returns original file ids on the jobs endpoints -- instead of the full original file
  • Adds a new parameter to the jobs endpoint to only return the jobs that are in the nomad queue.

Types of changes

  • New feature (non-breaking change which adds functionality)

Functional tests

Tested locally with AlexsLemonade/refinebio-frontend#784

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

image

@arielsvn arielsvn requested a review from davidsmejia November 6, 2019 14:39
@davidsmejia
Copy link
Contributor

This looks good but why did you remove the s3 urls from here?

https://github.com/AlexsLemonade/refinebio/pull/1867/files#diff-415cd6002ae0888c9bee613a31905f87L245-L247

@arielsvn
Copy link
Contributor Author

arielsvn commented Nov 6, 2019

This looks good but why did you remove the s3 urls from here?

I thought those were supposed to be internal. Users should be able to download computed files with download_url, assuming they provide a token. Do you think we should keep them public?

Copy link
Contributor

@davidsmejia davidsmejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏖

@arielsvn arielsvn merged commit 7dfc102 into dev Nov 6, 2019
@arielsvn arielsvn deleted the arielsvn/api-more-info branch November 6, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants