Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deploy issues #3422

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix deploy issues #3422

merged 1 commit into from
Oct 17, 2023

Conversation

arkid15r
Copy link
Contributor

Purpose/Implementation Notes

Fix deploy issues

  • Add stage env variables to api/workers
  • Revert terraform domain/vpc change

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@arkid15r
Fix deploy issues
1b22efb 
  - Add stage env variables to api/workers
  - Revert terraform domain/vpc change
@arkid15r arkid15r requested a review from davidsmejia October 17, 2023 16:51
davidsmejia
davidsmejia approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@davidsmejia davidsmejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkid15r arkid15r merged commit 517b276 into dev Oct 17, 2023
15 of 16 checks passed
@arkid15r arkid15r deleted the ark/fix-deploy-issues branch October 17, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsmejia davidsmejia davidsmejia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arkid15r @davidsmejia