Follow redirect when downloading gene_indexes #3444
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#3436
Purpose/Implementation Notes
NOTE: This PR encountered an error with isort that I could not reproduce locally. I saw that the repo we were using has recently changed so I am now targeting the branch that contains that fix. https://github.com/AlexsLemonade/refinebio/tree/davidsmejia/isort-upgrade-5.11.5
Running
docker run -it ccdlstaging/dr_no_op ls -l /home/user/gene_indexes
. Would give the correct output but rebuilding the container failed.While testing out the code locally I noticed that curling the
ID_REFINERY_URL
was not downloading the indexes and the subsequent unzip command exit code 9.This change tells curl to follow the redirect. Which then allows the no_op to build correctly.
This change invalidates the cache layer and makes the files available that were missing during the no_op tests.
Methods
n/a
Types of changes
Functional tests
List out the functional tests you've completed to verify your changes work locally.
Checklist
Screenshots
n/a