Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow redirect when downloading gene_indexes #3444

Closed

Conversation

davidsmejia
Copy link
Contributor

@davidsmejia davidsmejia commented Oct 27, 2023

Issue Number

#3436

Purpose/Implementation Notes

NOTE: This PR encountered an error with isort that I could not reproduce locally. I saw that the repo we were using has recently changed so I am now targeting the branch that contains that fix. https://github.com/AlexsLemonade/refinebio/tree/davidsmejia/isort-upgrade-5.11.5

Running docker run -it ccdlstaging/dr_no_op ls -l /home/user/gene_indexes. Would give the correct output but rebuilding the container failed.

While testing out the code locally I noticed that curling the ID_REFINERY_URL was not downloading the indexes and the subsequent unzip command exit code 9.

This change tells curl to follow the redirect. Which then allows the no_op to build correctly.

This change invalidates the cache layer and makes the files available that were missing during the no_op tests.

Methods

n/a

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Functional tests

List out the functional tests you've completed to verify your changes work locally.

Checklist

  • Lint and unit tests pass locally with my changes

Screenshots

n/a

@davidsmejia davidsmejia changed the base branch from dev to davidsmejia/isort-upgrade-5.11.5 October 27, 2023 22:53
@davidsmejia
Copy link
Contributor Author

closing in favor of #3446

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant