Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3452 Ensure /var/www/volumes_static exists on container restart #3455

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

davidsmejia
Copy link
Contributor

Issue Number

#3452

Purpose/Implementation Notes

This PR adds the same creation and permission settings to the static dir when the API container is restart. We have already moved the static dir out of tmp. This change could safely be removed in the future.

Thoughts for the future: We probably should consider pulling out the starting of the container to it's own script so that we can just call that remotely on the API instead of duplicating the setup in user data and deploy scripts. That change is more involved than what we need at this moment. If we encounter issues with the API standing up or docs not being available again I strongly recommend addressing that then.

Methods

n/a

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Functional tests

n/a

Checklist

  • Lint and unit tests pass locally with my changes

Screenshots

n/a

@davidsmejia davidsmejia requested a review from arkid15r November 7, 2023 18:34
Copy link
Contributor

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

infrastructure/deploy.sh Outdated Show resolved Hide resolved
Co-authored-by: Arkadii Yakovets <[email protected]>
@davidsmejia davidsmejia merged commit 401c869 into dev Nov 7, 2023
3 checks passed
@davidsmejia davidsmejia deleted the davidsmejia/3452-ensure-api-static-dir branch November 7, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants