-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update getting_started & sce_file_contents with celltyping instructions #193
Merged
sjspielman
merged 23 commits into
development
from
sjspielman/165-celltype-getting-started
Nov 15, 2023
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
55f6b74
Fix typo in clustering section and initiate the celltype section in g…
sjspielman ed5bfff
rearrange so that information about accessing data is only provided i…
sjspielman 0b5792d
Fix some typos and add rellink to metadata table
sjspielman 32c68b5
add ontology column for singler and predictions matrix for cellassign
sjspielman ad234e9
Add more about reference information, but left previous sentence to d…
sjspielman 4437490
fix spelling and some are -> is
sjspielman ec32dc7
remove some periods
sjspielman 7c629de
Takes care of #192
sjspielman 245cc5b
dont commit the spell check errors file...
sjspielman e84f4e3
Update docs/getting_started.md
sjspielman 44f8284
Refer to table for metadata and remove those code examples. Some addi…
sjspielman 7bfdfeb
indicate that submitter is less common and add sentence about QC report
sjspielman a746b2a
bulletify some of that text
sjspielman ef0f767
some cell type resources
sjspielman 572f219
Submitter-excluded title case, and condense singler ontology labels w…
sjspielman 23c8b40
also update bullet text per review
sjspielman b60f013
Apply suggestions from code review
sjspielman 886523a
Merge branch 'development' into sjspielman/165-celltype-getting-started
sjspielman 20349ed
condense sentences to 1 about referring to metadata for more info
sjspielman b652817
Update table with correct names, phrasing, hopefully...
sjspielman f10d7cb
Apply suggestions from code review
sjspielman 8bcd24a
one more spot to indicate that submitter may not always be present
sjspielman b0a7e85
panglaodb link and wording
sjspielman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, I think we want to add a little bit more context to this section. I would describe the references used in this first section. I would also mention the supplemental cell type report and that it's a good resource for evaluating the provided cell type annotations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added 2 links for cell annotation, but we could add more! Perhaps from this list we have going here? https://github.com/AlexsLemonade/training-specific-template/blob/main/additional-resources/single-cell-resources.md#cell-type-annotation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@allyhawkins this comment may have fallen by the wayside, any other links here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what you added is good!