Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use resource limits and update manifest and schema #811

Merged
merged 10 commits into from
Jan 29, 2025

Conversation

jashapiro
Copy link
Member

I had a branch from a bit ago where I updated a few things to new Nextflow standards, and I thought it might make sense to get this in as part of #810.

The changes here implement using the "new" resource limits in Nextflow.

While I was at it, I also updated the schema to match the current parameters, which included removing what I think is an unused CONDA_CONTAINER parameter.

I also updated some of the manifest to use the updated format, with additional information including the doi for the paper!

@jashapiro jashapiro requested a review from allyhawkins January 27, 2025 18:43
@jashapiro
Copy link
Member Author

I realized that this got a bit bigger than I was expecting when I had to update the GitHub actions, so if you think this should wait until after the 0.8.6 release, that is fine with me!

Copy link
Member

@allyhawkins allyhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that you did a test run of the workflow, LGTM

@jashapiro jashapiro merged commit 514756f into development Jan 29, 2025
4 checks passed
@jashapiro jashapiro deleted the jashapiro/nextflow-24 branch January 29, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants