-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tap_action support #668
base: master
Are you sure you want to change the base?
Conversation
I tested this PR on my install and it works great 👍 |
Thanks. This really works for PC, but I don't like idea of different behaviour for PC and Mobile. |
That would be fine for me. Let me know what you decide and I can update the PR. Should I also add the changes to the documentation, or do you prefer to do that? |
will this allow for showing the video in fullscreen with a single tap? |
Yes. I use it with a fullscreen browser_mod popup with another webrtc-camera card. |
I have a static image 99.9% of the time (updated whenever) but a button at the bottom left of my cards to go live at any point. |
I'm looking for this exact thing. However, I'm not a coder so I'm not understanding. Is there some YAML here I should add to the card, or does the developer have to add as a feature? |
hello, i would be very grateful for help, it is not possible for me to get tap_action to work in a custom:webrtc-camera card. What am I doing wrong here? I am on the completely wrong track?
(please ignore formatting - did not know how to get this right in this post) |
@codemunkie15 I copied your modified webrtc-camera.js over the /homeassistant/custom_components/webrtc/www/webrtc-camera.js and added tap_action to my config (I want to open a different Lovelace tab when I tap), but nothing happens. Any advise to make it work? Thanks.
|
@uspino2 not sure what has changed?!?
|
@AlexxIT Can you let me know how you want to proceed with this, to get it merged please? |
A'll check when I have time. |
I've added this to my personal HA, but having trouble getting it to work no matter where I tap.. Not sure if I'm missing something? tap_action: |
@codemunkie15 I understand this pr hasn't been merged yet... Does it work if applied to the latest releas? Thanks. |
Yes, still working fine for me on the latest release. |
I added these lines from your pr to
and then this to Lovelace:
...and still no |
@codemunkie15 I correct myself: I had to clear the cache on every browser to make it work. Thanks! |
Added
tap_action
support using the below method:https://developers.home-assistant.io/blog/2023/07/07/action-event-custom-cards/
I have not implemented
hold_action
ordouble_tap_action
because they interfere with the video player and need more thorough investigation.Note that on touchscreen devices (mobile/tablet) you have to set
ui: true
fortap_action
to work otherwise the html5 video controls swallow the click events. If you don't want to see the custom UI like me, you can easily hide it with a style: