Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static path config for HA 2024.7+ #723

Merged
merged 5 commits into from
Sep 8, 2024

Conversation

hmmbob
Copy link
Contributor

@hmmbob hmmbob commented Jul 2, 2024

Fixes #722

Needs HA 2024.7+ (but the warning is only shown on 2024.7+ as well)

Tested locally, works fine

@Snuffy2
Copy link

Snuffy2 commented Jul 10, 2024

I think you need to import StaticPathConfig
from homeassistant.components.http import StaticPathConfig

@hmmbob
Copy link
Contributor Author

hmmbob commented Jul 11, 2024

I think you need to import StaticPathConfig from homeassistant.components.http import StaticPathConfig

Yeah, great catch. Did that when testing locally, forgot to add it here. Many thanks!

@AlexxIT
Copy link
Owner

AlexxIT commented Jul 11, 2024

Thanks. But I won't accept this because breaking previous versions. A lot of users continue to use 2023.

@hmmbob
Copy link
Contributor Author

hmmbob commented Jul 11, 2024

I had an idea and made it backward compatible. Dropped the hacs.json change as well.

@hmmbob hmmbob changed the title Fix static path config Fix static path config for HA 2024.7+ Jul 11, 2024
@breakthestatic
Copy link

@AlexxIT, any chance this could be merged now that a backwards-compatible fix has been introduced? I tested the change locally on both a pre-2024.7 install as well as current release, 2024.8

@AlexxIT
Copy link
Owner

AlexxIT commented Aug 21, 2024

I need to test this before accepting.

@AlexxIT AlexxIT self-assigned this Aug 21, 2024
@AlexxIT AlexxIT merged commit 6c4e132 into AlexxIT:master Sep 8, 2024
2 checks passed
@AlexxIT
Copy link
Owner

AlexxIT commented Sep 8, 2024

Thanks!

@AlexxIT AlexxIT added this to the v3.6.0 milestone Sep 8, 2024
@hmmbob hmmbob deleted the fix_static_path_config branch September 8, 2024 09:19
AlexxIT added a commit that referenced this pull request Sep 8, 2024
@AlexxIT
Copy link
Owner

AlexxIT commented Oct 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants