Prevent errors other than autoplay errors from muting video #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robtpaton
force-pushed
the
better-autoplay-behaviour
branch
from
1eb4ef0
to
607f0bb
Compare
|
Thanks! |
AlexxIT
added a commit
that referenced
this pull request
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When there is a playback error, try to determine if it is an autoplay error before trying to play the video muted.
Why
Fixes #529 (at least in Chrome browsers).
When debugging #529 locally, I found many different playback errors get caught in the
catchblock (e.gThe play() request was interrupted by a new load request.). In these cases we don't want to mute the video, so I added a conditional to only unmute if the error is related to autoplay.After this change, I can successfully load a view with the video unmuted, in both Chrome Desktop and the Android Companion App. Safari is harder to fix because both autoplay and non-autoplay errors are reported as
AbortError.