Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add number of TPC clusters used for PID to AO2D #13617

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

mpuccio
Copy link
Contributor

@mpuccio mpuccio commented Oct 21, 2024

This is an alternative implementation to #13417, to be discussed at the next WP14 which one (if any) will go in production

@mpuccio mpuccio requested review from a team as code owners October 21, 2024 15:40
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@alibuild
Copy link
Collaborator

alibuild commented Oct 21, 2024

Error while checking build/O2/fullCI for 13ae48f at 2024-10-31 09:40:

## sw/BUILD/O2Physics-latest/log
/sw/slc8_x86-64/O2/13617-slc8_x86-64-local3/include/Framework/AnalysisHelpers.h:48:33: error: static assertion failed: Argument number mismatch
/sw/slc8_x86-64/O2/13617-slc8_x86-64-local3/include/Framework/AnalysisHelpers.h:50:11: error: no match for call to '(o2::framework::{anonymous}::memfun_type<void (o2::framework::TableBuilder::persist<float, unsigned int, unsigned int, unsigned char, signed char, signed char, signed char, unsigned char, unsigned char, float, float, float, float, float, float, float, float, float, float, float, float>(const std::array<const char*, 21>&)::<lambda(unsigned int, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<unsigned int>::FillType, o2::framework::BuilderMaker<unsigned int>::FillType, o2::framework::BuilderMaker<unsigned char>::FillType, o2::framework::BuilderMaker<signed char>::FillType, o2::framework::BuilderMaker<signed char>::FillType, o2::framework::BuilderMaker<signed char>::FillType, o2::framework::BuilderMaker<unsigned char>::FillType, o2::framework::BuilderMaker<unsigned char>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType)>::*)(unsigned int, float, unsigned int, unsigned int, unsigned char, signed char, signed char, signed char, unsigned char, unsigned char, float, float, float, float, float, float, float, float, float, float, float, float) const>::type {aka std::function<void(unsigned int, float, unsigned int, unsigned int, unsigned char, signed char, signed char, signed char, unsigned char, unsigned char, float, float, float, float, float, float, float, float, float, float, float, float)>}) (int, const float&, const unsigned int&, const unsigned char&, const unsigned char&, const signed char&, const signed char&, const unsigned char&, const unsigned char&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&)'
ninja: build stopped: subcommand failed.


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep ' error:'
++ grep -v clang-diagnostic-error error-log.txt
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/e952b82500f7ed88da862a00fd5e0e46538bac19/slc8_x86-64/o2checkcode/1.0-local368/etc/modulefiles
++ cat
--

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Nov 6, 2024

Error while checking build/O2/fullCI for b47babf at 2024-11-07 21:58:

## sw/BUILD/O2Physics-latest/log
/sw/slc8_x86-64/O2/13617-slc8_x86-64-local1/include/Framework/AnalysisHelpers.h:48:33: error: static assertion failed: Argument number mismatch
/sw/slc8_x86-64/O2/13617-slc8_x86-64-local1/include/Framework/AnalysisHelpers.h:50:11: error: no match for call to '(o2::framework::{anonymous}::memfun_type<void (o2::framework::TableBuilder::persist<float, unsigned int, unsigned int, unsigned char, signed char, signed char, signed char, unsigned char, unsigned char, float, float, float, float, float, float, float, float, float, float, float, float>(const std::array<const char*, 21>&)::<lambda(unsigned int, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<unsigned int>::FillType, o2::framework::BuilderMaker<unsigned int>::FillType, o2::framework::BuilderMaker<unsigned char>::FillType, o2::framework::BuilderMaker<signed char>::FillType, o2::framework::BuilderMaker<signed char>::FillType, o2::framework::BuilderMaker<signed char>::FillType, o2::framework::BuilderMaker<unsigned char>::FillType, o2::framework::BuilderMaker<unsigned char>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType)>::*)(unsigned int, float, unsigned int, unsigned int, unsigned char, signed char, signed char, signed char, unsigned char, unsigned char, float, float, float, float, float, float, float, float, float, float, float, float) const>::type {aka std::function<void(unsigned int, float, unsigned int, unsigned int, unsigned char, signed char, signed char, signed char, unsigned char, unsigned char, float, float, float, float, float, float, float, float, float, float, float, float)>}) (int, const float&, const unsigned int&, const unsigned char&, const unsigned char&, const signed char&, const signed char&, const unsigned char&, const unsigned char&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&)'
ninja: build stopped: subcommand failed.

Full log here.

@mpuccio
Copy link
Contributor Author

mpuccio commented Nov 8, 2024

@pzhristov on Monday we can merge this (better not just before the weekend)

@mpuccio
Copy link
Contributor Author

mpuccio commented Nov 19, 2024

@pzhristov we are ready to merge (note that GH had issues today at some point, so the failures of the actions are not related). The current PR does not disturb O2Physics, but will enable us to commit the converters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants