-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qatable #13633
base: dev
Are you sure you want to change the base?
Qatable #13633
Conversation
REQUEST FOR PRODUCTION RELEASES:
This will add The following labels are available |
Hello @f3sch Thank you for the pull request. Here is the link to the corresponding material: github issue:
|
undrafting to check CI |
Thank you for following. |
Internal information - test at GSI using debug streamer:
|
Hello @f3sch, Thank you for implementing the changes. I have identified two major issues so far:
Additionally, I would recommend using consistent variable names in both the source code and the debug stream to make it easier to test and ensure code consistency. The code for testing I committed to the tpc gitlab, I am not sure if we have some code for the O2 testing. I produced QA plots with that. Thank you for your help Marian |
Track Residual Coding:
After the fix, the pulls—normalized errors—are now close to one (as should be) as shown in the slide. Test code used in slide: |
Signed-off-by: Felix Schlepper <[email protected]>
@miranov25 at your leisure, I updated the code and uploaded updated files for you to test at the path posted above. |
Hello @f3sch, Thank you very much for making the changes. I see you have modified the Beta0 estimator as we discussed and agreed upon. However, there is another adjustment needed related to the sampling. In the current code, you are using sampling with 1 sigma resolution, but we need to sample it with 5 bins per sigma (to be able to correct later) I will add the proposed modification directly to the code, temporarily as a hardcoded number. Additional modifications needed
For the sampling of sigma/5, we should see approximately 5 bins in Best regards
|
For now, I suggest modifying the A more elegant approach would be to create |
@miranov25 I do not understand, please send me the code you want to have changed, or add it here as a commit. |
@miranov25