CMake: Show compiler warnings, allow ccache

CMake: Fix disappearing analysis targets

builds/cmake/OJ-misc.cmake

@@ -13,9 +13,35 @@ if(CMAKE_VERSION VERSION_LESS "3.24")
 	endif()
 endif()
 
+
+# compiler cache
+option(WANT_CCACHE "Use ccache to speed up rebuilds" OFF)
+if(WANT_CCACHE)
+	if(NOT FOUND_CCACHE)
+		find_program(CCACHE_EXECUTABLE ccache)
+
+		if(CCACHE_EXECUTABLE)
+			message(STATUS "Using ccache as CXX compiler launcher")
+			set(FOUND_CCACHE 1 CACHE INTERNAL "Ccache has been found")
+		endif()
+	endif()
+
+	if(CCACHE_EXECUTABLE)
+		set(CMAKE_CXX_COMPILER_LAUNCHER "${CCACHE_EXECUTABLE}")
+	endif()
+endif()
+
+# warnings
+if(MSVC)
+	add_compile_options(/W4)
+else()
+	add_compile_options(-Wall -Wextra)
+endif()
+
 # global scope, since ASAN needs to catch all targets
-option(WANT_ASAN "build with adress sanitizer" OFF)
+option(WANT_ASAN "build with address sanitizer" OFF)
 if(WANT_ASAN)
+	message(STATUS "Building with address sanitizer")
 	add_compile_options(-fno-omit-frame-pointer -fsanitize=address)
 	add_link_options(-fno-omit-frame-pointer -fsanitize=address)
 endif()
@@ -30,57 +56,58 @@ if(NOT FOUND_ASTYLE)
 
 	if(ASTYLE_EXECUTABLE)
 		message(STATUS "Found source code formatter: astyle")
-
-		list(APPEND ASTYLE_ARGS
-			--suffix=none
-			--style=attach
-			--indent=tab=4
-			--pad-oper
-			--pad-header
-			--unpad-paren
-			--max-code-length=100
-			--break-after-logical
-			--attach-closing-while
-			--align-pointer=type
-			--align-reference=name
-			--indent-classes
-			--indent-preproc-block
-			--indent-switches
-			--min-conditional-indent=0)
-
-		add_custom_target(format
-			COMMAND ${ASTYLE_EXECUTABLE} ${ASTYLE_ARGS} ${ALL_SRC}
-			COMMENT "Running astyle to format source code"
-			VERBATIM)
-
 		set(FOUND_ASTYLE 1 CACHE INTERNAL "Astyle has been found")
 	endif()
 endif()
+if(ASTYLE_EXECUTABLE)
+	list(APPEND ASTYLE_ARGS
+		--suffix=none
+		--style=attach
+		--indent=tab=4
+		--pad-oper
+		--pad-header
+		--unpad-paren
+		--max-code-length=100
+		--break-after-logical
+		--attach-closing-while
+		--align-pointer=type
+		--align-reference=name
+		--indent-classes
+		--indent-preproc-block
+		--indent-switches
+		--min-conditional-indent=0)
+
+	add_custom_target(format
+		COMMAND ${ASTYLE_EXECUTABLE} ${ASTYLE_ARGS} ${ALL_SRC}
+		COMMENT "Running astyle to format source code"
+		VERBATIM)
+endif()
 
 if(NOT FOUND_CPPCHECK)
 	find_program(CPPCHECK_EXECUTABLE cppcheck)
-
 	if(CPPCHECK_EXECUTABLE)
 		message(STATUS "Found static analysis tool: cppcheck")
-
-		list(APPEND CPPCHECK_ARGS
-			--enable=warning,style,performance,portability,unusedFunction
-			#--std=c++11
-			--std=c++03
-			--language=c++
-			-I${CMAKE_CURRENT_SOURCE_DIR}/src
-			-U__SYMBIAN32__ -UUIQ3 # unmaintained
-			#--enable=information
-		)
-
-		add_custom_target(cppcheck
-			COMMAND ${CPPCHECK_EXECUTABLE} ${CPPCHECK_ARGS} ${ALL_SRC}
-			COMMENT "Running cppcheck for static analysis"
-			USES_TERMINAL VERBATIM)
-
 		set(FOUND_CPPCHECK 1 CACHE INTERNAL "Cppcheck has been found")
 	endif()
 endif()
+if(CPPCHECK_EXECUTABLE)
+	list(APPEND CPPCHECK_ARGS
+		--enable=warning,style,performance,portability,unusedFunction
+		--std=c++11
+		--language=c++
+		-I${CMAKE_CURRENT_SOURCE_DIR}/src
+		-U__SYMBIAN32__ -UUIQ3 -UENABLE_JJ2        # unmaintained
+		-UGP2X -UWIZ -UDINGOO -UCAANOO -UGAMESHELL # contributed
+		-UPSP -U__vita__ -U_3DS -U__wii__          # homebrew
+		-U__riscos__
+		#--enable=information
+	)
+
+	add_custom_target(cppcheck
+		COMMAND ${CPPCHECK_EXECUTABLE} ${CPPCHECK_ARGS} ${ALL_SRC}
+		COMMENT "Running cppcheck for static analysis"
+		USES_TERMINAL VERBATIM)
+endif()
 
 if(NOT FOUND_ASTYLE AND NOT FOUND_CPPCHECK)
 	message(STATUS "No source code formatter or static analysis tool enabled.")