Simplify applying bitwise operators on sign extended values #1111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the result of comparison and logical operators in C is of type
int
, complex logical expressions may result in expression trees where sext, extract and logical operators are used together (especially when the programmer uses temporary variables of typeint
to store boolean values and instcombine has not been executed).This PR introduces the following simplifications for bit vectors of the same width
a
andb
:The pattern
extract(sext(x), ...)
is already handled by the existing simplifications.If this breaks other important cases, it might be possible to enforce that
a.bits() = b.bits() = 1
, although I have personally seen a major impact anywhere else yet.