chan_tlb.c: finddelim update limit to length of strp from str #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkmer
added
the
code quality
mkmer
force-pushed
the
TLB-Channel
branch
3 times, most recently
from
c47c93f to
f5f5f3d
Compare
mkmer
commented
Jan 30, 2025
channels/chan_tlb.c
Outdated
| @@ -519,6 +519,9 @@ static int finddelim(char *str, char *strp[], int limit) | |||
| l++; | |||
| strp[i++] = str + 1; | |||
| } | |||
| if (i => limit) { | |||
| break; | |||
| } | |||
| } | |||
| strp[i] = 0; | |||
There was a problem hiding this comment.
I'm not sure this makes sense to 0 the last pointer value in the array of pointers.
i => limit at least makes sure we are not writing outside of the limit
There was a problem hiding this comment.
I agree. It's OK to fill the last slot of the array ... as long as the call sites are iterating with for (i = 0; i < n; i++) {}. But, we would need the last element to be NULL if the usage is while (*ptr) {}. Regardless, if we have an array of size 10 we don't want to write to array[10].
There was a problem hiding this comment.
Ah - I see my problem. 0 based counts 0 - 9 = length of 10...
mkmer
force-pushed
the
TLB-Channel
branch
3 times, most recently
from
0ba8e05 to
fda2659
Compare
Allan-N
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the correct length to prevent over running the output pointer.