Skip to content

Commit

Permalink
Merge pull request #474 from Almenon/fix_silent_err
Browse files Browse the repository at this point in the history
Fix silent err
  • Loading branch information
Almenon authored Nov 19, 2024
2 parents dc6c013 + 088e5e6 commit 8eeb7e2
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions src/PreviewManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ export default class PreviewManager {
private warnIfOutdatedPythonVersion(pythonPath: string){
PythonShell.getVersion(`"${pythonPath}"`).then((out)=>{
let version = out.stdout ? out.stdout : out.stderr
if(version?.includes("Python 3.4") || version?.includes("Python 2")){
if(version?.includes("Python 2") || version?.includes("Python 3.4") || version?.includes("Python 3.5") || version?.includes("Python 3.6")){
vscode.window.showErrorMessage(`AREPL no longer supports ${version}.
Please upgrade or set AREPL.pythonPath to a diffent python.
AREPL needs python 3.7 or greater`)
Expand All @@ -199,9 +199,7 @@ export default class PreviewManager {
// if we get spawn error here thats already reported by telemetry
// so we skip telemetry reporting for this error
console.error(err)
if(err.message.includes("Python was not found but can be installed from the Microsoft Store")){
vscode.window.showErrorMessage(err.message)
}
vscode.window.showErrorMessage(err.message)
})
}

Expand Down

0 comments on commit 8eeb7e2

Please sign in to comment.