Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to vtk-m 2.1 #1236

Merged
merged 24 commits into from
Dec 11, 2023
Merged

update to vtk-m 2.1 #1236

merged 24 commits into from
Dec 11, 2023

Conversation

cyrush
Copy link
Member

@cyrush cyrush commented Dec 6, 2023

No description provided.

@cyrush
Copy link
Member Author

cyrush commented Dec 6, 2023

WIP

@nicolemarsaglia this includes necessary the changes from https://github.com/Alpine-DAV/ascent/tree/task/2023_08_vtk-m_2.1_update_side_test

That branch also has some slice debugging changes that I don't want to rectify, so instead I moved what we needed over here.

@cyrush
Copy link
Member Author

cyrush commented Dec 6, 2023

For HIP, I am building VTK-m 2.1 with Kokkos 3.7.2

When compiling VTK-m, I get an error related to thurst.

**** Configuring VTK-m v2.1.0
-- The C compiler identification is Clang 14.0.0
-- The CXX compiler identification is Clang 14.0.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /opt/rocm/llvm/bin/amdclang - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /opt/rocm/llvm/bin/amdclang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found Git: /usr/bin/git (found version "2.25.1") 
-- Could not use git to determine source version, using version 2.1.0
-- Enabled Kokkos devices: SERIAL;HIP
-- The HIP compiler identification is Clang 14.0.0
-- Detecting HIP compiler ABI info
-- Detecting HIP compiler ABI info - done
-- Check for working HIP compiler: /opt/rocm-5.1.3/llvm/bin/clang++ - skipped
-- Detecting HIP compile features
-- Detecting HIP compile features - done
/__w/ascent/ascent/vtk-m-v2.1.0/vtkm/cont/kokkos/internal/DeviceAdapterAlgorithmKokkos.h:47:10: fatal error: 'thrust/device_ptr.h' file not found
#include <thrust/device_ptr.h>

Here is the kokkos configure for ref:

**** Configuring Kokkos 3.7.02
-- Setting default Kokkos CXX standard to 14
-- The CXX compiler identification is Clang 14.0.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /opt/rocm//bin/hipcc - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- The project name is: Kokkos
Traceback (most recent call last):
  File "/opt/rocm-5.1.3/bin/rocm_agent_enumerator", line 257, in <module>
    main()
  File "/opt/rocm-5.1.3/bin/rocm_agent_enumerator", line 241, in main
    target_list = readFromKFD()
  File "/opt/rocm-5.1.3/bin/rocm_agent_enumerator", line 193, in readFromKFD
    for node in sorted(os.listdir(topology_dir)):
FileNotFoundError: [Errno 2] No such file or directory: '/sys/class/kfd/kfd/topology/nodes/'
-- Compiler Version: 5.1.20532
-- Using -std=gnu++14 for C++14 extensions as feature
-- Built-in Execution Spaces:
--     Device Parallel: Kokkos::Experimental::HIP
--     Host Parallel: NoTypeDefined
--       Host Serial: SERIAL
-- 
-- Architectures:
--  VEGA90A
-- Found TPLLIBDL: /usr/include  
-- Using internal desul_atomics copy
-- Kokkos Devices: SERIAL;HIP, Kokkos Backends: SERIAL;HIP
-- Configuring done
-- Generating done

@cyrush
Copy link
Member Author

cyrush commented Dec 11, 2023

zlib doesn't need cxx compiler set:

CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_CXX_COMPILER

@cyrush cyrush merged commit b6f9b3a into develop Dec 11, 2023
19 checks passed
@cyrush cyrush deleted the task/2023_12_vtkm_2.1_update branch December 11, 2023 16:21
@cyrush
Copy link
Member Author

cyrush commented Dec 11, 2023

For HIP, I am building VTK-m 2.1 with Kokkos 3.7.2

When compiling VTK-m, I get an error related to thurst.

**** Configuring VTK-m v2.1.0
-- The C compiler identification is Clang 14.0.0
-- The CXX compiler identification is Clang 14.0.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /opt/rocm/llvm/bin/amdclang - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /opt/rocm/llvm/bin/amdclang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found Git: /usr/bin/git (found version "2.25.1") 
-- Could not use git to determine source version, using version 2.1.0
-- Enabled Kokkos devices: SERIAL;HIP
-- The HIP compiler identification is Clang 14.0.0
-- Detecting HIP compiler ABI info
-- Detecting HIP compiler ABI info - done
-- Check for working HIP compiler: /opt/rocm-5.1.3/llvm/bin/clang++ - skipped
-- Detecting HIP compile features
-- Detecting HIP compile features - done
/__w/ascent/ascent/vtk-m-v2.1.0/vtkm/cont/kokkos/internal/DeviceAdapterAlgorithmKokkos.h:47:10: fatal error: 'thrust/device_ptr.h' file not found
#include <thrust/device_ptr.h>

Here is the kokkos configure for ref:

**** Configuring Kokkos 3.7.02
-- Setting default Kokkos CXX standard to 14
-- The CXX compiler identification is Clang 14.0.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /opt/rocm//bin/hipcc - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- The project name is: Kokkos
Traceback (most recent call last):
  File "/opt/rocm-5.1.3/bin/rocm_agent_enumerator", line 257, in <module>
    main()
  File "/opt/rocm-5.1.3/bin/rocm_agent_enumerator", line 241, in main
    target_list = readFromKFD()
  File "/opt/rocm-5.1.3/bin/rocm_agent_enumerator", line 193, in readFromKFD
    for node in sorted(os.listdir(topology_dir)):
FileNotFoundError: [Errno 2] No such file or directory: '/sys/class/kfd/kfd/topology/nodes/'
-- Compiler Version: 5.1.20532
-- Using -std=gnu++14 for C++14 extensions as feature
-- Built-in Execution Spaces:
--     Device Parallel: Kokkos::Experimental::HIP
--     Host Parallel: NoTypeDefined
--       Host Serial: SERIAL
-- 
-- Architectures:
--  VEGA90A
-- Found TPLLIBDL: /usr/include  
-- Using internal desul_atomics copy
-- Kokkos Devices: SERIAL;HIP, Kokkos Backends: SERIAL;HIP
-- Configuring done
-- Generating done

Resolved with a vtk-m patch from spack that allows you to turn of thrust support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant