-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding actions for opening, flushing, and closing the logs #1442
Adding actions for opening, flushing, and closing the logs #1442
Conversation
this looks great! Can you add a note to the CHANGELOG.md file about these actions and a short section in the docs? We can think about the mpi relevant options We could also add support for The separate actions for log and echo thresholds are a good addition. |
Yes, I can add a note to the change log. I have a draft of the MPI relevant options but I don't have tests written for it yet so I didn't push them. I like the idea of adding the log threshold to the options for open_log. That should be a quick change so I will add that too. |
7d76632
to
08beb6d
Compare
@cyrush I circled back to this and updated the MPI thresholding to be Debug for rank 0 and Warnings for all other ranks. Does that work? |
@emily-howell sounds good, thanks! |
Merging, thanks again for this! |
This currently only adds some simple actions for opening, flushing, and closing the logs. I wonder if it would be useful to also add an action for modifying the logging threshold?