-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature / Gas Tank #1135
Merged
Merged
Feature / Gas Tank #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superKalo
reviewed
Jan 20, 2025
superKalo
reviewed
Feb 5, 2025
superKalo
reviewed
Feb 5, 2025
superKalo
reviewed
Feb 5, 2025
superKalo
reviewed
Feb 5, 2025
superKalo
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We went though a few feedback cycles and I'm now happy with the final state.
I left a few final minor notes, but I approve the PR.
PS: Please fix the failing unit test before you merge it.
FAIL src/controllers/main/main.test.ts
● Test suite failed to run
src/libs/estimate/estimate.ts:423:61 - error TS23[39](https://github.com/AmbireTech/ambire-common/actions/runs/13158008405/job/36719500082?pr=1135#step:6:40): Property 'availableAmount' does not exist on type 'TokenResult'.
423 const availableAmount = token.flags.onGasTank ? token.availableAmount || token.amount : feeTokenOutcomes[key].amount
~~~~~~~~~~~~~~~
PetromirDev
requested changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
cashbackStatusByAccount
property to the Portfolio Controller to manage the state of when the Confetti banner and Confetti Modal should be visible.Added a
getIsFirstCashbackReceived
helper function to determine whether the first cashback has been received.Introduced a
getFirstCashbackBanners
function inbanners.ts
.Updated the SelectAccount Controller to use
getFirstCashbackBanners
for displaying a banner when a user receives their first cashback, if applicable.Added a unit test for the changes related to cashback, availableAmount, and saved. This test is currently disabled and will be enabled once the required Relayer changes are applied.