Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature / Gas Tank #1135

Merged
merged 50 commits into from
Feb 12, 2025
Merged

Feature / Gas Tank #1135

merged 50 commits into from
Feb 12, 2025

Conversation

Maskln
Copy link
Contributor

@Maskln Maskln commented Nov 28, 2024

  • Added cashbackStatusByAccount property to the Portfolio Controller to manage the state of when the Confetti banner and Confetti Modal should be visible.

  • Added a getIsFirstCashbackReceived helper function to determine whether the first cashback has been received.

  • Introduced a getFirstCashbackBanners function in banners.ts.

  • Updated the SelectAccount Controller to use getFirstCashbackBanners for displaying a banner when a user receives their first cashback, if applicable.

  • Added a unit test for the changes related to cashback, availableAmount, and saved. This test is currently disabled and will be enabled once the required Relayer changes are applied.

Copy link
Member

@superKalo superKalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We went though a few feedback cycles and I'm now happy with the final state.

I left a few final minor notes, but I approve the PR.

PS: Please fix the failing unit test before you merge it.

FAIL src/controllers/main/main.test.ts
  ● Test suite failed to run

    src/libs/estimate/estimate.ts:423:61 - error TS23[39](https://github.com/AmbireTech/ambire-common/actions/runs/13158008405/job/36719500082?pr=1135#step:6:40): Property 'availableAmount' does not exist on type 'TokenResult'.

    423       const availableAmount = token.flags.onGasTank ? token.availableAmount || token.amount : feeTokenOutcomes[key].amount
                                                                    ~~~~~~~~~~~~~~~

src/controllers/portfolio/portfolio.ts Outdated Show resolved Hide resolved
src/controllers/portfolio/portfolio.ts Show resolved Hide resolved
src/controllers/portfolio/portfolio.ts Show resolved Hide resolved
@Maskln Maskln merged commit 880c5cb into v2 Feb 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants