-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Pull25 #32
Open
dennisdegreef
wants to merge
13
commits into
AmsterdamPHP:master
Choose a base branch
from
dennisdegreef:pull25
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WIP] Pull25 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added gulp and node-sass to remove ruby deps - moved in compass replacements - added proper asset building with gulp - moved source stuff to source - added circle and deploy scripts, untested yet.
For some weird reason the cache seems to always be populated with the full event list, not the filtered one. Moved the filtering to afterwards, so its always filtered before render, this way I don't care about cache. There I fixed it™ /gif deal with it.
Nightmare tests simulate usage of raffler to ensure everything is ok. Runs against the PHP Web Server.
rdohms
requested changes
Oct 3, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to request changes, it seems you did not make any changes. I got lots of changes, i got the best changes! Can i give you some changes?
There are no changes, I wanted to trigger CircleCI, and by pushing your PR though my fork, now I can ;-) I am debugging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.