Added a dedicated fill and replace tool #345
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made type name a property
This can be managed by the version change
Also localised a bit of text
This adds the block define panel to a dialog and hooks it up to the block button. Formatting changes. Bug fixes. Added the operations to a scrollable panel
When run this will show all of the UI elements making testing easier
Removed wildcard mode. This is going to get its own class that can do more.
This still needs some work
Cleaned up events Added extra_properties to multiple variants
By adding * in the inputs means that the keyword arguments cannot be given as normal arguments. This should make it a lot easier to add keyword arguments in the future
Renamed to ChoiceRaw which seems like a better name. Kept the old name for backwards compatibility. Added choices input in init. Added option to set from tuple of (obj, str). Dict is a bit limited because each key must be hashable and unique. Added SetObject method
Also partially rewritten the single properties
If the default is not found it will auto to the first option
If the data was not known it would throw an error. Once that was fixed it just set a blank dictionary. Added is_supported property to check if the data has a specification file.
Simplified the multi select popup to handle only strings. Added a property to define valid states in the state manager.
Events were being fired twice because they were being run in the set logic rather than the on change logic. Moved the firing logic to the UI elements that the user changes. Fixed some issues in the state manager.
This will make it so that each class does not need to store the translation manager as well.
Parent arguments are passed through as kwargs rather than redeclaring each argument. Added support to limit platforms and block formats within the state. This was previously done in the UI.
The previous init method could be given either a state class or the translation manager and optional data from which the state would be constructed. This was needlessly complicated. The new init method is given just the state. That can be constructed and given or the classmethod from_data will create it and pass it to the init emulating the old behaviour.
Added a copy method which seems better than requiring the copy library. Added a list to the state holder to store child state holders. When the state is set these will be notified of the new state.
The methods have been moved to a base class. The stored state must now be an instance of StrEnum to allow other places to define their own enum extensions.
The text is now updated automatically when the state is changed. The child size event is fired when the state changes. The state of the widget is set to None so that the methods bound to the state get unloaded.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still needs a lot of work