upper bound for pyzmq/jupyter_client for notebook<7 #202
Conversation
|
FYI, these pins will be built into notebook 6.5.5 already. But we need these for older versions, otherwise conda is likely to downgrade notebook to get newer versions of jupyter_client and pyzmq. |
|
Notebook 5 already has an upper bound for |
| if name == "notebook": | ||
| replace_dep(depends, "tornado >=4", "tornado >=4,<6") | ||
| if int(version.split('.', 1)[0]) < 7: | ||
| replace_dep(depends, "pyzmq >=17", "pyzmq >=17,<25") | ||
| replace_dep(depends, "jupyter_client >=5.3.4", "jupyter_client >=5.3.4,<8") |
There was a problem hiding this comment.
It looks like notebook version 5.0.0-6.0.1 ether pins to jupyter_client>=5.2.0 or doesn't pin at all. Do those need the upper bound as well? Or is some other constraint protecting us here?
There was a problem hiding this comment.
In practice most of these are built for old versions of python, but notebook-5.7.9-py38_0 might still slip through.
|
I've deleted the branch and change the settings of this repo to do it automatically after merge |
| replace_dep(depends, "pyzmq >=17", "pyzmq >=17,<25") | ||
| replace_dep(depends, "jupyter_client >=5.3.4", "jupyter_client >=5.3.4,<8") | ||
| replace_dep(depends, "jupyter_client >=5.2.0", "jupyter_client >=5.2.0,<8") | ||
| replace_dep(depends, "jupyter_client", "jupyter_client <8") | ||
|
|
There was a problem hiding this comment.
pins added in response to comment
See this PR and linked issues:
jupyter/notebook#6749