#132 Connector Redesign [WIP] #201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lohann
commented
Oct 27, 2023
Comment on lines
14
to
18
| serde(rename_all = "camelCase") | ||
| )] | ||
| pub struct Block<TX> { | ||
| /// Hash of the block | ||
| pub hash: H256, |
There was a problem hiding this comment.
I had to re-implement some ethers-rs primitives because they didn't implement scale-codec and scale-info traits.
I'm using the scale-info to generate the metadata for allowing timegraph and other components to parse the encoded task.
Lohann
commented
Oct 27, 2023
chains/ethereum/config/src/types.rs
Outdated
Comment on lines
387
to
409
| #[derive(Decode, Encode)] | ||
| pub enum Query { | ||
| /// Returns the balance of the account of given address. | ||
| GetBalance(GetBalanceQuery), | ||
| /// Returns the value from a storage position at a given address. | ||
| GetStorageAt(GetStorageAtQuery), | ||
| /// Returns the receipt of a transaction by transaction hash. | ||
| GetTransactionReceipt(GetTransactionReceiptQuery), | ||
| /// Executes a new message call immediately without creating a transaction on the block | ||
| /// chain. | ||
| CallContract(CallContractQuery), | ||
| /// Returns the account and storage values of the specified account including the | ||
| /// Merkle-proof. This call can be used to verify that the data you are pulling | ||
| /// from is not tampered with. | ||
| GetProof { | ||
| /// Address of the Account | ||
| address: Address, | ||
| /// an array of storage-keys that should be proofed and included | ||
| storage_keys: Vec<U256>, | ||
| /// State at the block | ||
| block: BlockIdentifier, | ||
| }, | ||
| } |
There was a problem hiding this comment.
This is the new definition of ethereum read-only tasks, this type is scale encoded/decoded by the connector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Connector Redesign - Work in Progress
This work drastically changes the connector api, some changes includes:
Fixes #132
Type of change
Code review prechecks: